forked from pool/slurm
Egbert Eich
364aa9908a
- Update to 18.08.04, with following highlights
* Fix message sent to user to display preempted instead of time limit when
a job is preempted.
* Fix memory leak when a failure happens processing a nodes gres config.
* Improve error message when failures happen processing a nodes gres config.
* Don't skip jobs in scontrol hold.
* Allow --cpu-bind=verbose to be used with SLURM_HINT environment variable.
* Enhanced handling for runaway jobs
* cons_res: Delay exiting cr_job_test until after cores/cpus are calculated
and distributed.
* Don't check existence of srun --prolog or --epilog executables when set to
"none" and SLURM_TEST_EXEC is used.
* Add "P" suffix support to job and step tres specifications.
* Fix jobacct_gather/cgroup to work correctly when more than one task is
started on a node.
* salloc - set SLURM_NTASKS_PER_CORE and SLURM_NTASKS_PER_SOCKET in the
environment if the corresponding command line options are used.
* slurmd - fix handling of the -f flag to specify alternate config file
locations.
* Add SchedulerParameters option of bf_ignore_newly_avail_nodes to avoid
scheduling lower priority jobs on resources that become available during
the backfill scheduling cycle when bf_continue is enabled.
* job_submit/lua: Add several slurmctld return codes and add user/group info
* salloc/sbatch/srun - print warning if mutually exclusive options of --mem
and --mem-per-cpu are both set.
- Refreshed:
* pam_slurm_adopt-avoid-running-outside-of-the-sshd-PA.patch
OBS-URL: https://build.opensuse.org/request/show/663733
OBS-URL: https://build.opensuse.org/package/show/network:cluster/slurm?expand=0&rev=81
33 lines
1.1 KiB
Diff
33 lines
1.1 KiB
Diff
From a5d4481c05e2afa1ff1920446663e66c48ef9277 Mon Sep 17 00:00:00 2001
|
|
From: Matthias Gerstner <matthias.gerstner@suse.de>
|
|
Date: Wed, 5 Dec 2018 14:08:07 +0100
|
|
Subject: [PATCH 2/3] pam_slurm_adopt: send_user_msg: don't copy undefined data
|
|
into message
|
|
|
|
Using memcpy, an amount of undefined data from the stack will be copied
|
|
into the target buffer. While pam_conv probably doesn't evalute the
|
|
extra data it still unclean to do that. It could lead up to an
|
|
information leak somewhen.
|
|
|
|
Signed-off-by: Christian Goll <cgoll@suse.de>
|
|
---
|
|
contribs/pam_slurm_adopt/helper.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/contribs/pam_slurm_adopt/helper.c b/contribs/pam_slurm_adopt/helper.c
|
|
index 9c3e202a87..1bac0a0fcf 100644
|
|
--- a/contribs/pam_slurm_adopt/helper.c
|
|
+++ b/contribs/pam_slurm_adopt/helper.c
|
|
@@ -128,7 +128,7 @@ send_user_msg(pam_handle_t *pamh, const char *mesg)
|
|
|
|
/* Construct msg to send to app.
|
|
*/
|
|
- memcpy(str, mesg, sizeof(str));
|
|
+ strncpy(str, mesg, sizeof(str));
|
|
msg[0].msg_style = PAM_ERROR_MSG;
|
|
msg[0].msg = str;
|
|
pmsg[0] = &msg[0];
|
|
--
|
|
2.16.4
|
|
|