Accepting request 678202 from security:Stunnel

OBS-URL: https://build.opensuse.org/request/show/678202
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/stunnel?expand=0&rev=14

stunnel.changes

@@ -1,3 +1,15 @@
+-------------------------------------------------------------------
+Fri Feb 22 07:49:21 UTC 2019 - Franck Bui <fbui@suse.com>
+
+- Drop use of $FIRST_ARG in .spec
+
+  The use of $FIRST_ARG was probably required because of the
+  %service_* rpm macros were playing tricks with the shell positional
+  parameters. This is bad practice and error prones so let's assume
+  that no macros should do that anymore and hence it's safe to assume
+  that positional parameters remains unchanged after any rpm macro
+  call.
+
 -------------------------------------------------------------------
 Sun Nov 11 11:08:22 UTC 2018 - obs@botter.cc
 

stunnel.spec

@@ -1,7 +1,7 @@
 #
 # spec file for package stunnel
 #
-# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -12,7 +12,7 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
@@ -154,7 +154,7 @@ if ! test -s etc/stunnel/stunnel.conf; then
         echo copying default config file to %{_sysconfdir}/stunnel/stunnel.conf
 fi
 # first installation?
-if [ ${FIRST_ARG:-0} = 1 ] && [ ! -f etc/stunnel/stunnel.pem ]; then
+if [ $1 = 1 ] && [ ! -f etc/stunnel/stunnel.pem ]; then
         cat usr/share/doc/packages/stunnel/README.%{VENDORAFFIX}
 fi