From c9fa25772f267b641a82be319b3820017738d03c247944417dcdaa5dc222493d Mon Sep 17 00:00:00 2001 From: Robert Milasan Date: Tue, 2 Sep 2014 12:58:23 +0000 Subject: [PATCH] Accepting request 247221 from home:rmilasan:branches:Base:System - udev: add option to generate old 'buggy' serials (bnc#886852) Add 1066-udev-add-compatibility-links-for-truncated-by-id-links.patch - udev: add option to generate old 'buggy' serials (bnc#886852) Add 1066-udev-add-compatibility-links-for-truncated-by-id-links.patch OBS-URL: https://build.opensuse.org/request/show/247221 OBS-URL: https://build.opensuse.org/package/show/Base:System/systemd?expand=0&rev=766 --- ...lity-links-for-truncated-by-id-links.patch | 167 ++++++++++++++++++ systemd-mini.changes | 6 + systemd-mini.spec | 3 + systemd.changes | 6 + systemd.spec | 3 + 5 files changed, 185 insertions(+) create mode 100644 1066-udev-add-compatibility-links-for-truncated-by-id-links.patch diff --git a/1066-udev-add-compatibility-links-for-truncated-by-id-links.patch b/1066-udev-add-compatibility-links-for-truncated-by-id-links.patch new file mode 100644 index 00000000..3bb4d407 --- /dev/null +++ b/1066-udev-add-compatibility-links-for-truncated-by-id-links.patch @@ -0,0 +1,167 @@ +From: Jeff Mahoney +Subject: udev: add option to generate old 'buggy' serials +References: bnc#886852 + +Prior to udev 184, scsi_id would truncate the last character of the model +string when generating the ID_SERIAL value. If a system was installed +prior to that fix being available in udev, there may be configuration +information that refers to the truncated link. + +This patch adds a --truncated-serial option and a udev rule will created +the old truncated links. + +Signed-off-by: Jeff Mahoney +--- + rules/60-persistent-storage.rules | 4 ++++ + src/udev/scsi_id/scsi_id.c | 15 ++++++++++++++- + src/udev/scsi_id/scsi_id.h | 1 + + src/udev/scsi_id/scsi_serial.c | 19 +++++++++++++------ + 4 files changed, 32 insertions(+), 7 deletions(-) + +--- a/rules/60-persistent-storage.rules ++++ b/rules/60-persistent-storage.rules +@@ -46,6 +46,10 @@ KERNEL=="sd*|cciss*", ENV{DEVTYPE}=="par + KERNEL=="sd*[!0-9]", ENV{ID_BUS}=="ata", PROGRAM="scsi_id --whitelisted --replace-whitespace -p0x80 -d $devnode", RESULT=="?*", ENV{ID_SCSI_COMPAT}="$result", SYMLINK+="disk/by-id/scsi-$env{ID_SCSI_COMPAT}" + KERNEL=="sd*[0-9]", ENV{ID_SCSI_COMPAT}=="?*", SYMLINK+="disk/by-id/scsi-$env{ID_SCSI_COMPAT}-part%n" + ++# scsi compat links for ATA devices (for compatibility with udev < 184) ++KERNEL=="sd*[!0-9]", ENV{ID_BUS}=="ata", PROGRAM="scsi_id --truncated-serial --whitelisted --replace-whitespace -p0x80 -d$tempnode", RESULT=="?*", ENV{ID_SCSI_COMPAT_TRUNCATED}="$result", SYMLINK+="disk/by-id/scsi-$env{ID_SCSI_COMPAT_TRUNCATED}" ++KERNEL=="sd*[0-9]", ENV{ID_SCSI_COMPAT_TRUNCATED}=="?*", SYMLINK+="disk/by-id/scsi-$env{ID_SCSI_COMPAT_TRUNCATED}-part%n" ++ + # firewire + KERNEL=="sd*[!0-9]|sr*", ATTRS{ieee1394_id}=="?*", SYMLINK+="disk/by-id/ieee1394-$attr{ieee1394_id}" + KERNEL=="sd*[0-9]", ATTRS{ieee1394_id}=="?*", SYMLINK+="disk/by-id/ieee1394-$attr{ieee1394_id}-part%n" +--- a/src/udev/scsi_id/scsi_id.c ++++ b/src/udev/scsi_id/scsi_id.c +@@ -44,6 +44,7 @@ static const struct option options[] = { + { "replace-whitespace", no_argument, NULL, 'u' }, + { "sg-version", required_argument, NULL, 's' }, + { "verbose", no_argument, NULL, 'v' }, ++ { "truncated-serial", no_argument, NULL, '9' }, + { "version", no_argument, NULL, 'V' }, /* don't advertise -V */ + { "export", no_argument, NULL, 'x' }, + { "help", no_argument, NULL, 'h' }, +@@ -56,6 +57,7 @@ static char config_file[MAX_PATH_LEN] = + static enum page_code default_page_code = PAGE_UNSPECIFIED; + static int sg_version = 4; + static int debug = 0; ++static bool compat_truncated = false; + static bool reformat_serial = false; + static bool export = false; + static char vendor_str[64]; +@@ -323,6 +325,7 @@ static void help(void) { + " -g,--whitelisted threat device as whitelisted\n" + " -u,--replace-whitespace replace all whitespace by underscores\n" + " -v,--verbose verbose logging\n" ++ " --truncated-serial truncated serial for compatibility with systems configured with by-id links created by udev < 184\n" + " --version print version\n" + " -x,--export print values as environment keys\n" + " -h,--help print this help text\n\n"); +@@ -393,6 +396,10 @@ static int set_options(struct udev *udev + debug++; + break; + ++ case '9': ++ compat_truncated = true; ++ break; ++ + case 'V': + printf("%s\n", VERSION); + exit(0); +@@ -535,6 +542,9 @@ static int scsi_id(struct udev *udev, ch + util_replace_whitespace(dev_scsi.serial, serial_str, sizeof(serial_str)); + util_replace_chars(serial_str, NULL); + printf("ID_SERIAL=%s\n", serial_str); ++ util_replace_whitespace(dev_scsi.serial_compat, serial_str, sizeof(serial_str)); ++ util_replace_chars(serial_str, NULL); ++ printf("ID_SERIAL_COMPAT=%s\n", serial_str); + util_replace_whitespace(dev_scsi.serial_short, serial_str, sizeof(serial_str)); + util_replace_chars(serial_str, NULL); + printf("ID_SERIAL_SHORT=%s\n", serial_str); +@@ -565,7 +575,10 @@ static int scsi_id(struct udev *udev, ch + if (reformat_serial) { + char serial_str[MAX_SERIAL_LEN]; + +- util_replace_whitespace(dev_scsi.serial, serial_str, sizeof(serial_str)); ++ if (compat_truncated) ++ util_replace_whitespace(dev_scsi.serial_compat, serial_str, sizeof(serial_str)); ++ else ++ util_replace_whitespace(dev_scsi.serial, serial_str, sizeof(serial_str)); + util_replace_chars(serial_str, NULL); + printf("%s\n", serial_str); + goto out; +--- a/src/udev/scsi_id/scsi_id.h ++++ b/src/udev/scsi_id/scsi_id.h +@@ -43,6 +43,7 @@ struct scsi_id_device { + char kernel[64]; + char serial[MAX_SERIAL_LEN]; + char serial_short[MAX_SERIAL_LEN]; ++ char serial_compat[MAX_SERIAL_LEN]; + int use_sg; + + /* Always from page 0x80 e.g. 'B3G1P8500RWT' - may not be unique */ +--- a/src/udev/scsi_id/scsi_serial.c ++++ b/src/udev/scsi_id/scsi_serial.c +@@ -97,7 +97,8 @@ static const char hex_str[]="0123456789a + + static int do_scsi_page80_inquiry(struct udev *udev, + struct scsi_id_device *dev_scsi, int fd, +- char *serial, char *serial_short, int max_len); ++ char *serial, char *serial_short, ++ char *serial_compat, int max_len); + + static int sg_err_category_new(struct udev *udev, + int scsi_status, int msg_status, int +@@ -620,7 +621,7 @@ static int do_scsi_page83_inquiry(struct + unsigned char page_83[SCSI_INQ_BUFF_LEN]; + + /* also pick up the page 80 serial number */ +- do_scsi_page80_inquiry(udev, dev_scsi, fd, NULL, unit_serial_number, MAX_SERIAL_LEN); ++ do_scsi_page80_inquiry(udev, dev_scsi, fd, NULL, unit_serial_number, NULL, MAX_SERIAL_LEN); + + memzero(page_83, SCSI_INQ_BUFF_LEN); + retval = scsi_inquiry(udev, dev_scsi, fd, 1, PAGE_83, page_83, +@@ -765,7 +766,8 @@ static int do_scsi_page83_prespc3_inquir + /* Get unit serial number VPD page */ + static int do_scsi_page80_inquiry(struct udev *udev, + struct scsi_id_device *dev_scsi, int fd, +- char *serial, char *serial_short, int max_len) ++ char *serial, char *serial_short, ++ char *serial_compat, int max_len) + { + int retval; + int ser_ind; +@@ -799,9 +801,14 @@ static int do_scsi_page80_inquiry(struct + ser_ind = prepend_vendor_model(udev, dev_scsi, &serial[1]); + if (ser_ind < 0) + return 1; ++ if (serial_compat) ++ strcpy(serial_compat, serial); + ser_ind++; /* for the leading 'S' */ +- for (i = 4; i < len + 4; i++, ser_ind++) ++ for (i = 4; i < len + 4; i++, ser_ind++) { + serial[ser_ind] = buf[i]; ++ if (serial_compat) ++ serial_compat[ser_ind - 1] = buf[i]; ++ } + } + if (serial_short != NULL) { + memcpy(serial_short, &buf[4], len); +@@ -877,7 +884,7 @@ int scsi_get_serial(struct udev *udev, + return 1; + + if (page_code == PAGE_80) { +- if (do_scsi_page80_inquiry(udev, dev_scsi, fd, dev_scsi->serial, dev_scsi->serial_short, len)) { ++ if (do_scsi_page80_inquiry(udev, dev_scsi, fd, dev_scsi->serial, dev_scsi->serial_short, dev_scsi->serial_compat, len)) { + retval = 1; + goto completed; + } else { +@@ -951,7 +958,7 @@ int scsi_get_serial(struct udev *udev, + for (ind = 4; ind <= page0[3] + 3; ind++) + if (page0[ind] == PAGE_80) + if (!do_scsi_page80_inquiry(udev, dev_scsi, fd, +- dev_scsi->serial, dev_scsi->serial_short, len)) { ++ dev_scsi->serial, dev_scsi->serial_short, dev_scsi->serial_compat, len)) { + /* + * Success + */ diff --git a/systemd-mini.changes b/systemd-mini.changes index a86bec56..33ae215d 100644 --- a/systemd-mini.changes +++ b/systemd-mini.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Tue Sep 2 12:56:47 UTC 2014 - rmilasan@suse.com + +- udev: add option to generate old 'buggy' serials (bnc#886852) + Add 1066-udev-add-compatibility-links-for-truncated-by-id-links.patch + ------------------------------------------------------------------- Tue Sep 2 09:14:03 UTC 2014 - werner@suse.de diff --git a/systemd-mini.spec b/systemd-mini.spec index 7e4b1f1f..3f55c4dc 100644 --- a/systemd-mini.spec +++ b/systemd-mini.spec @@ -965,6 +965,8 @@ Patch1063: 1063-udev-path_id-suppress-ID_PATH-for-devices-with-an-un.patch Patch1064: 1064-udev-hwdb-do-not-look-at-usb_device-parents.patch # PATCH-FIX-UPSTREAM 1065-udev-bump-event-timeout-to-60-seconds.patch Patch1065: 1065-udev-bump-event-timeout-to-60-seconds.patch +# PATCH-FIX-SUSE 1066-udev-add-compatibility-links-for-truncated-by-id-links.patch (bnc#886852) +Patch1066: 1066-udev-add-compatibility-links-for-truncated-by-id-links.patch %description Systemd is a system and service manager, compatible with SysV and LSB @@ -1612,6 +1614,7 @@ cp %{SOURCE7} m4/ %patch1063 -p0 %patch1064 -p0 %patch1065 -p0 +%patch1066 -p1 # remove patch backups find -name '*.orig' -exec rm -f '{}' \+ diff --git a/systemd.changes b/systemd.changes index a86bec56..33ae215d 100644 --- a/systemd.changes +++ b/systemd.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Tue Sep 2 12:56:47 UTC 2014 - rmilasan@suse.com + +- udev: add option to generate old 'buggy' serials (bnc#886852) + Add 1066-udev-add-compatibility-links-for-truncated-by-id-links.patch + ------------------------------------------------------------------- Tue Sep 2 09:14:03 UTC 2014 - werner@suse.de diff --git a/systemd.spec b/systemd.spec index 35e9d036..2c4dca48 100644 --- a/systemd.spec +++ b/systemd.spec @@ -960,6 +960,8 @@ Patch1063: 1063-udev-path_id-suppress-ID_PATH-for-devices-with-an-un.patch Patch1064: 1064-udev-hwdb-do-not-look-at-usb_device-parents.patch # PATCH-FIX-UPSTREAM 1065-udev-bump-event-timeout-to-60-seconds.patch Patch1065: 1065-udev-bump-event-timeout-to-60-seconds.patch +# PATCH-FIX-SUSE 1066-udev-add-compatibility-links-for-truncated-by-id-links.patch (bnc#886852) +Patch1066: 1066-udev-add-compatibility-links-for-truncated-by-id-links.patch %description Systemd is a system and service manager, compatible with SysV and LSB @@ -1607,6 +1609,7 @@ cp %{SOURCE7} m4/ %patch1063 -p0 %patch1064 -p0 %patch1065 -p0 +%patch1066 -p1 # remove patch backups find -name '*.orig' -exec rm -f '{}' \+