forked from pool/systemd
6a62c05e32
- Add upstream patches as real fixes 0001-activate-fix-fd-leak-in-do_accept.patch 0002-analyze-avoid-a-null-dereference.patch 0003-analyze-fix-mem-leak.patch 0004-backlight-Avoid-error-when-state-restore-is-disabled.patch 0005-bus-avoid-using-m-kdbus-after-freeing-it.patch 0006-bus-unref-buscreds-on-failure.patch 0007-core-fix-a-potential-mem-leak.patch 0008-core-smack-setup-Actually-allow-for-succesfully-load.patch 0009-journal-do-not-leak-mmaps-on-OOM.patch 0010-manager-use-correct-cleanup-function.patch - Intergrate the work of Robert and rename the patch 1068-udev-remove-userspace-firmware-loading-support.patch to 1078-udev-remove-userspace-firmware-loading-support.patch Also add patch 1079-udev-remove-userspace-firmware-loading-support.patch to apply the same change for opensuse 13.2 and above - Add upstream patch 0001-systemctl-allow-to-change-the-default-target-without.patch to allow to override default target without --force (bnc#896664) - Add upstream patches for udev 1068-udev-net_setup_link-export-the-.link-filename-applie.patch 1069-rules-net-setup-link-preserve-ID_NET_LINK_FILE-and-I.patch 1070-rules-net-setup-link-remove-stray-linebreak.patch 1071-udev-import-the-full-db-on-MOVE-events-for-devices-w.patch 1072-udev-netif_rename-don-t-log-to-kmsg.patch 1073-udev-drop-print_kmsg.patch 1074-udev-fix-copy-paste-error-in-log-message.patch OBS-URL: https://build.opensuse.org/request/show/249581 OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/systemd?expand=0&rev=206
33 lines
1.0 KiB
Diff
33 lines
1.0 KiB
Diff
From 2b347169b9046ff2d735ef23e62a8c74f5151600 Mon Sep 17 00:00:00 2001
|
|
From: Philippe De Swert <philippedeswert@gmail.com>
|
|
Date: Wed, 10 Sep 2014 12:20:42 +0300
|
|
Subject: [PATCH] bus: unref buscreds on failure
|
|
|
|
Actually unref the buscreds when we are not going to return a
|
|
pointer to them. As when bus_creds_add_more fails we immediately
|
|
return the error code otherwise and leak the new buscreds.
|
|
Found with coverity. Fixes: CID#1237761
|
|
---
|
|
src/libsystemd/sd-bus/sd-bus.c | 4 +++-
|
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
|
diff --git src/libsystemd/sd-bus/sd-bus.c src/libsystemd/sd-bus/sd-bus.c
|
|
index 78e91b9..83b3aa1 100644
|
|
--- src/libsystemd/sd-bus/sd-bus.c
|
|
+++ src/libsystemd/sd-bus/sd-bus.c
|
|
@@ -3339,8 +3339,10 @@ _public_ int sd_bus_get_peer_creds(sd_bus *bus, uint64_t mask, sd_bus_creds **re
|
|
}
|
|
|
|
r = bus_creds_add_more(c, mask, pid, 0);
|
|
- if (r < 0)
|
|
+ if (r < 0) {
|
|
+ sd_bus_creds_unref(c);
|
|
return r;
|
|
+ }
|
|
|
|
*ret = c;
|
|
return 0;
|
|
--
|
|
1.7.9.2
|
|
|