forked from pool/systemd
16ef4de12e
- Fix creation of /dev/root link. - Add remount-ro-before-unmount.patch: always remount read-only before unmounting in final shutdown loop. - Add switch-root-try-pivot-root.patch: try pivot_root before overmounting / - links more manpages for migrated tools (from Christopher Yeleighton). - disable boot.localnet service, ypbind service will do the right thing now (bnc#716746) - add xdm-display-manager.patch: pull xdm.service instead of display-manager.service (needed until xdm initscript is migrated to native systemd service). - Add fix-permissions-btmp.patch: ensure btmp is owned only by root (bnc#777405). - Have the udev package create a tape group, as referenced by 50-udev-default.rules and 60-persistent-storage-tape.rules (DimStar). - Add fix-bad-memory-access.patch: fix crash in journal rotation. - Add fix-dbus-crash.patch: fix D-Bus caused crash. - Add sync-on-shutdown.patch: ensure sync is done when initiating shutdown. - Add mount-efivars.patch: mount efivars if booting on UEFI. - Ship a empty systemd-journald initscript in systemd-logger to stop insserv to complain about missing syslog dependency. - Update 0001-service-Fix-dependencies-added-when-parsing-insserv..patch with bug fixes from Debian. OBS-URL: https://build.opensuse.org/request/show/142568 OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/systemd?expand=0&rev=115
33 lines
1.2 KiB
Diff
33 lines
1.2 KiB
Diff
From 645a9e5a2bbb06464a3fba1a3501e9d79e5bbad8 Mon Sep 17 00:00:00 2001
|
|
From: Eelco Dolstra <eelco.dolstra@logicblox.com>
|
|
Date: Wed, 31 Oct 2012 11:53:56 +0100
|
|
Subject: [PATCH] dbus-manager: fix a fatal dbus abort in
|
|
bus_manager_message_handler()
|
|
|
|
If ListUnitFiles fails, or an OOM occurs, then dbus_message_unref()
|
|
will be called twice on "reply", causing systemd to crash. So remove
|
|
the call to dbus_message_unref(); it is unnecessary because of
|
|
the cleanup attribute on "reply".
|
|
|
|
[zj: modified to leave one dbus_message_unref() alone, per Colin
|
|
Walters' comment.]
|
|
---
|
|
src/core/dbus-manager.c | 1 -
|
|
1 file changed, 1 deletion(-)
|
|
|
|
diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c
|
|
index 2010241..3cf3e90 100644
|
|
--- a/src/core/dbus-manager.c
|
|
+++ b/src/core/dbus-manager.c
|
|
@@ -1436,7 +1436,6 @@ static DBusHandlerResult bus_manager_message_handler(DBusConnection *connection,
|
|
r = unit_file_get_list(m->running_as == SYSTEMD_SYSTEM ? UNIT_FILE_SYSTEM : UNIT_FILE_USER, NULL, h);
|
|
if (r < 0) {
|
|
unit_file_list_free(h);
|
|
- dbus_message_unref(reply);
|
|
return bus_send_error_reply(connection, message, NULL, r);
|
|
}
|
|
|
|
--
|
|
1.7.10.4
|
|
|