rpm/tboot
SHA256
1
0
Fork 0
forked from pool/tboot
Code Pull Requests Activity

Accepting request 1196424 from security

Browse Source 
- add tboot-fix-alloc-size-warning.patch: newest GCC spits out this error:
  ```
  pconf_legacy.c: In function ‘create’:
  pconf_legacy.c:327:16: error: allocation of insufficient size ‘20’ for type ‘tb_hash_t’ with size ‘64’ [-Werror=alloc-size]
  327 |         digest = malloc(SHA1_DIGEST_SIZE);
      |                ^
  ```
  There's a union data type behind this. It's not an actual error. To get rid
  of the warning, the patch allocates the full union size, thereby wasting a
  bit of memory.

OBS-URL: https://build.opensuse.org/request/show/1196424
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/tboot?expand=0&rev=50
This commit is contained in:
Dominique Leuenberger 2024-08-28 19:32:25 +00:00 committed by Git OBS Bridge
commit 9e4dcdaefa
3 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tboot-fix-alloc-size-warning.patch Normal file
View File

@ -0,0 +1,13 @@
Index: tboot-1.11.4/lcptools-v2/pconf_legacy.c
===================================================================
--- tboot-1.11.4.orig/lcptools-v2/pconf_legacy.c
+++ tboot-1.11.4/lcptools-v2/pconf_legacy.c
@@ -324,7 +324,7 @@ static lcp_policy_element_t *create(void
ERROR("Error: no pcrs were selected.\n");
return NULL;
}
- digest = malloc(SHA1_DIGEST_SIZE);
+ digest = malloc(sizeof(*digest));
if (digest == NULL) {
ERROR("Error: failed to allocate memory for digest buffer.\n");
return NULL;

16
tboot.changes
View File

@ -1,3 +1,19 @@
-------------------------------------------------------------------
Wed Aug 28 08:27:34 UTC 2024 - Matthias Gerstner <matthias.gerstner@suse.com>
- add tboot-fix-alloc-size-warning.patch: newest GCC spits out this error:
```
pconf_legacy.c: In function ‘create’:
pconf_legacy.c:327:16: error: allocation of insufficient size ‘20’ for type ‘tb_hash_t’ with size ‘64’ [-Werror=alloc-size]
327 | digest = malloc(SHA1_DIGEST_SIZE);
| ^
```
There's a union data type behind this. It's not an actual error. To get rid
of the warning, the patch allocates the full union size, thereby wasting a
bit of memory.
-------------------------------------------------------------------
Tue Jun 25 07:34:57 UTC 2024 - Matthias Gerstner <matthias.gerstner@suse.com>

1
tboot.spec
View File

@ -31,6 +31,7 @@ Patch4: tboot-grub2-fix-xen-submenu-name.patch
Patch7: tboot-distributor.patch
Patch8: tboot-grub2-refuse-secure-boot.patch
Patch9: tboot-bsc#1207833-copy-mbi.patch
Patch10: tboot-fix-alloc-size-warning.patch
BuildRoot: %{_tmppath}/%{name}-%{version}-build
ExclusiveArch: %{ix86} x86_64
BuildRequires: openssl-devel