saltbundle/venv-salt-minion
SHA256
7
0
Fork 4
Code Pull Requests 2 Activity

Fix the typo causing buiding EL9 bundle without binary dependencies #21

Manually merged
vizhestkov merged 1 commits from bundle_next_el9_deps_fix into bundle_next 2026-02-17 11:32:38 +01:00
Conversation 5 Commits 1 Files Changed 2 +6 -1
vizhestkov commented 2026-02-16 14:51:53 +01:00
Owner
Copy Link

sed expression contain typo: doubled /d; causing error sed: -e expression #1, char 57: extra characters after command which is almost invisible in build log and not causing build fail, but producing rpm package with no binary dependencies:

/bin/sh
/bin/sh
/bin/sh
/bin/sh
/bin/sh
config(venv-salt-minion) = 3006.0-58.28.uyuni
logrotate
policycoreutils
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1
systemd

instead of:

/bin/sh
/bin/sh
/bin/sh
/bin/sh
/bin/sh
/usr/bin/bash
config(venv-salt-minion) = 3006.0-2.1
ld-linux-x86-64.so.2()(64bit)
ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)
libbz2.so.1()(64bit)
libc.so.6()(64bit)
libc.so.6(GLIBC_2.10)(64bit)
libc.so.6(GLIBC_2.13)(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.15)(64bit)
libc.so.6(GLIBC_2.16)(64bit)
libc.so.6(GLIBC_2.17)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.25)(64bit)
libc.so.6(GLIBC_2.26)(64bit)
libc.so.6(GLIBC_2.27)(64bit)
libc.so.6(GLIBC_2.28)(64bit)
libc.so.6(GLIBC_2.3)(64bit)
libc.so.6(GLIBC_2.3.2)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.32)(64bit)
libc.so.6(GLIBC_2.33)(64bit)
libc.so.6(GLIBC_2.34)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libc.so.6(GLIBC_2.5)(64bit)
libc.so.6(GLIBC_2.6)(64bit)
libc.so.6(GLIBC_2.7)(64bit)
libc.so.6(GLIBC_2.9)(64bit)
libcrypto.so.3()(64bit)
libcrypto.so.3(OPENSSL_3.0.0)(64bit)
libcrypto.so.3(OPENSSL_3.3.0)(64bit)
libcrypto.so.3(OPENSSL_3.4.0)(64bit)
libcurl.so.4()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
liblzma.so.5()(64bit)
liblzma.so.5(XZ_5.0)(64bit)
libm.so.6()(64bit)
libm.so.6(GLIBC_2.2.5)(64bit)
libm.so.6(GLIBC_2.29)(64bit)
libreadline.so.8()(64bit)
libsqlite3.so.0()(64bit)
libssl.so.3()(64bit)
libssl.so.3(OPENSSL_3.0.0)(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.2)(64bit)
libstdc++.so.6(CXXABI_1.3.9)(64bit)
libstdc++.so.6(GLIBCXX_3.4)(64bit)
libstdc++.so.6(GLIBCXX_3.4.11)(64bit)
libstdc++.so.6(GLIBCXX_3.4.15)(64bit)
libstdc++.so.6(GLIBCXX_3.4.19)(64bit)
libstdc++.so.6(GLIBCXX_3.4.20)(64bit)
libstdc++.so.6(GLIBCXX_3.4.21)(64bit)
libstdc++.so.6(GLIBCXX_3.4.29)(64bit)
libstdc++.so.6(GLIBCXX_3.4.9)(64bit)
libuuid.so.1()(64bit)
libuuid.so.1(UUID_2.20)(64bit)
libz.so.1()(64bit)
libz.so.1(ZLIB_1.2.0)(64bit)
logrotate
policycoreutils
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1
rtld(GNU_HASH)
systemd

IMPORTANT: the fixed regular expression is adding libcrypt.so to be filtered out, but it's not the same as libcrypto.so (this one is a part of OpenSSL).

`sed` expression contain typo: doubled `/d;` causing error `sed: -e expression #1, char 57: extra characters after command` which is almost invisible in build log and not causing build fail, but producing `rpm` package with no binary dependencies: ``` /bin/sh /bin/sh /bin/sh /bin/sh /bin/sh config(venv-salt-minion) = 3006.0-58.28.uyuni logrotate policycoreutils rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 systemd ``` instead of: ``` /bin/sh /bin/sh /bin/sh /bin/sh /bin/sh /usr/bin/bash config(venv-salt-minion) = 3006.0-2.1 ld-linux-x86-64.so.2()(64bit) ld-linux-x86-64.so.2(GLIBC_2.3)(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.10)(64bit) libc.so.6(GLIBC_2.13)(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.15)(64bit) libc.so.6(GLIBC_2.16)(64bit) libc.so.6(GLIBC_2.17)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.25)(64bit) libc.so.6(GLIBC_2.26)(64bit) libc.so.6(GLIBC_2.27)(64bit) libc.so.6(GLIBC_2.28)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.2)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.32)(64bit) libc.so.6(GLIBC_2.33)(64bit) libc.so.6(GLIBC_2.34)(64bit) libc.so.6(GLIBC_2.4)(64bit) libc.so.6(GLIBC_2.5)(64bit) libc.so.6(GLIBC_2.6)(64bit) libc.so.6(GLIBC_2.7)(64bit) libc.so.6(GLIBC_2.9)(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libcrypto.so.3(OPENSSL_3.3.0)(64bit) libcrypto.so.3(OPENSSL_3.4.0)(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblzma.so.5()(64bit) liblzma.so.5(XZ_5.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libm.so.6(GLIBC_2.29)(64bit) libreadline.so.8()(64bit) libsqlite3.so.0()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.15)(64bit) libstdc++.so.6(GLIBCXX_3.4.19)(64bit) libstdc++.so.6(GLIBCXX_3.4.20)(64bit) libstdc++.so.6(GLIBCXX_3.4.21)(64bit) libstdc++.so.6(GLIBCXX_3.4.29)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_2.20)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) logrotate policycoreutils rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 rtld(GNU_HASH) systemd ``` IMPORTANT: the fixed regular expression is adding `libcrypt.so` to be filtered out, but it's not the same as `libcrypto.so` (this one is a part of OpenSSL).
vizhestkov added 1 commit 2026-02-16 14:51:54 +01:00
Remove filtering out libcrypt and libssl dependencies 5ef8e9cfd8
autogits-devel requested review from PSuarezHernandez 2026-02-16 14:51:59 +01:00
autogits-devel requested review from agraul 2026-02-16 14:51:59 +01:00
autogits-devel requested review from mczernek 2026-02-16 14:51:59 +01:00
autogits-devel requested review from ygutierrez 2026-02-16 14:51:59 +01:00
PSuarezHernandez reviewed 2026-02-16 15:00:01 +01:00
PSuarezHernandez left a comment
Owner
Copy Link

Wouldn't getting rid of this affect to current supported openEuler 22.03 in Uyuni?

Wouldn't getting rid of this affect to current supported openEuler 22.03 in Uyuni?
vizhestkov commented 2026-02-16 15:03:40 +01:00
Author
Owner
Copy Link

It could, but it's not the full fix yet, will check possible issues on my testing VMs. Will try to prepare the fix in next first and then move to testing all required changes. Or is it better to prepare full fix in the branch project in OBS first?

It could, but it's not the full fix yet, will check possible issues on my testing VMs. Will try to prepare the fix in `next` first and then move to `testing` all required changes. Or is it better to prepare full fix in the branch project in OBS first?
autogits_obs_staging_bot commented 2026-02-16 16:39:56 +01:00
Member
Copy Link

Build successful, for more information go in https://build.opensuse.org/project/show/systemsmanagement:saltstack:bundle:scm:next:PullRequest:157.

Build successful, for more information go in https://build.opensuse.org/project/show/systemsmanagement:saltstack:bundle:scm:next:PullRequest:157.
autogits-devel requested review from PSuarezHernandez 2026-02-16 16:39:59 +01:00
vizhestkov force-pushed bundle_next_el9_deps_fix from 5ef8e9cfd8 to a9af70fdfc 2026-02-16 17:10:06 +01:00 Compare
vizhestkov changed title from Remove filtering out libcrypt and libssl dependencies to Fix the typo causing buiding EL9 bundle without binary dependencies 2026-02-16 17:10:38 +01:00
autogits_obs_staging_bot commented 2026-02-16 17:13:16 +01:00
Member
Copy Link

Build successful, for more information go in https://build.opensuse.org/project/show/systemsmanagement:saltstack:bundle:scm:next:PullRequest:157.

Build successful, for more information go in https://build.opensuse.org/project/show/systemsmanagement:saltstack:bundle:scm:next:PullRequest:157.
PSuarezHernandez approved these changes 2026-02-17 11:31:06 +01:00
autogits-devel removed review request for agraul 2026-02-17 11:32:32 +01:00
autogits-devel removed review request for mczernek 2026-02-17 11:32:32 +01:00
autogits-devel removed review request for ygutierrez 2026-02-17 11:32:32 +01:00
vizhestkov manually merged commit a9af70fdfc into bundle_next 2026-02-17 11:32:38 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
PSuarezHernandez
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
PSuarezHernandez agraul autogits-devel autogits_obs_staging_bot mczernek vizhestkov ygutierrez zypp-team
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: saltbundle/venv-salt-minion#21
Delete Branch "bundle_next_el9_deps_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?