Be a bit more verbose what changes the recent cleanup caused.

+ Make all BuildRequires, PreReq, and Provides a separate line.
  + Use %{buildroot} instead of ${RPM_BUILD_ROOT}.
  + Use straight commands instead of macros (make, install).
  + Use -p in post and postun if we only call one command.
  + Use %{_localstatedir} instead of %{_var} in the filelist.
  + Remove superfluous AutoReqProv on lines.

OBS-URL: https://build.opensuse.org/package/show/network:samba:STABLE/samba?expand=0&rev=188

build-source-timestamp

@@ -1,2 +1,2 @@
-2629
+2630
 Branch      : trunk

samba-doc.spec

@@ -434,7 +434,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %changelog

samba.changes

@@ -2,6 +2,12 @@
 Fri Sep  9 13:08:58 UTC 2011 - lmuelle@suse.de
 
 - Spec file cleanup as suggested by the spec-cleaner tool.
+  + Make all BuildRequires, PreReq, and Provides a separate line.
+  + Use %{buildroot} instead of ${RPM_BUILD_ROOT}.
+  + Use straight commands instead of macros (make, install).
+  + Use -p in post and postun if we only call one command.
+  + Use %{_localstatedir} instead of %{_var} in the filelist.
+  + Remove superfluous AutoReqProv on lines.
 
 -------------------------------------------------------------------
 Thu Sep  8 19:29:36 UTC 2011 - lmuelle@suse.de

samba.spec

@@ -205,7 +205,7 @@ Authors:
     The Samba Team <samba@samba.org>
 
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package client
@@ -249,7 +249,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %if 0%{?suse_version} == 0 || 0%{?suse_version} > 1020
@@ -275,7 +275,7 @@ Authors:
     The Samba Team <samba@samba.org>
 
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %endif
@@ -305,7 +305,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %endif
@@ -332,7 +332,7 @@ Authors:
 --------
     Jeremy Allison <jra at samba dot org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %if %{make_utils}
@@ -353,7 +353,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %endif
@@ -388,7 +388,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %if 0%{?suse_version} && 0%{?suse_version} < 1031
@@ -414,14 +414,14 @@ PreReq:         /sbin/ldconfig
 
 %description -n libsmbclient
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %else
 
 %description -n libsmbclient0
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %endif
@@ -469,7 +469,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libnetapi0
@@ -487,7 +487,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libnetapi-devel
@@ -511,7 +511,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %if 0%{?suse_version} && 0%{?suse_version} < 1031
@@ -532,14 +532,14 @@ PreReq:         /sbin/ldconfig
 
 %description -n libsmbsharemodes
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %else
 
 %description -n libsmbsharemodes0
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %endif
@@ -575,7 +575,7 @@ Authors:
     The Samba Team <samba@samba.org>
 
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libwbclient0
@@ -593,7 +593,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libwbclient-devel
@@ -617,7 +617,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libtalloc2
@@ -637,7 +637,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libtalloc-devel
@@ -663,7 +663,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libtdb1
@@ -683,7 +683,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libtdb-devel
@@ -705,7 +705,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libtevent0
@@ -725,7 +725,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libtevent-devel
@@ -753,7 +753,7 @@ Authors:
     The Samba Team <samba@samba.org>
 
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libldb1
@@ -775,7 +775,7 @@ Authors:
     The Samba Team <samba@samba.org>
 
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %package -n libldb-devel
@@ -802,7 +802,7 @@ Authors:
 --------
     The Samba Team <samba@samba.org>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %if %{make_ldapsmb}
@@ -825,7 +825,7 @@ Authors:
 --------
     Guenther Deschner <guenther at deschner dot de>
 
-Source Timestamp: 2629
+Source Timestamp: 2630
 Branch      : trunk
 
 %endif

vendor-files.tar.bz2

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:1f913c24b79f4e9e69a43c56c0accd4ee7961e3c82afd44ea5b5df81253f5788
+oid sha256:a2cac10a5cdb2924330646d5b3e166b466b035916bcc90cfc095ef5b16e5ab83
-size 51436
+size 51417