suse-edge/Factory
SHA256
11
0
Fork 4
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

init for chart version updates #14

Merged
dprodanov merged 1 commits from update-charts-version into main 2024-11-18 12:55:34 +01:00
Conversation 3 Commits 1 Files Changed 7 +23 -23
dprodanov commented 2024-11-14 09:59:14 +01:00
Owner
Copy Link
No description provided.
dprodanov added 1 commit 2024-11-14 09:59:15 +01:00
dprodanov requested review from steven.hardy 2024-11-14 09:59:24 +01:00
steven.hardy requested changes 2024-11-14 14:48:32 +01:00
Dismissed
steven.hardy left a comment
Owner
Copy Link

lgtm other than the comment re subcharts, IMO we should avoid changing those if it's not needed so rebasing against upstream versions is easier.

lgtm other than the comment re subcharts, IMO we should avoid changing those if it's not needed so rebasing against upstream versions is easier.
metal3-chart/Chart.yaml Outdated
@ -7,3 +7,3 @@
name: baremetal-operator
repository: file://./charts/baremetal-operator
version: 0.5.0
version: 302.0.0_up0.5.0
steven.hardy commented 2024-11-14 14:47:29 +01:00
Owner
Copy Link

Do we need to update the sub-chart versions? AFAICS we don't and this will make rebasing to new versions from upstream more difficult?

Do we need to update the sub-chart versions? AFAICS we don't and this will make rebasing to new versions from upstream more difficult?
dprodanov commented 2024-11-15 09:34:14 +01:00
Author
Owner
Copy Link

I was not sure if we wanted to upgrade them and I agree with your point so will revert the sub-charts.

I was not sure if we wanted to upgrade them and I agree with your point so will revert the sub-charts.
dprodanov marked this conversation as resolved
steven.hardy commented 2024-11-14 19:33:34 +01:00
Owner
Copy Link

We may need to do some testing but do we also want to align the BuildTag as helm says:

OCI artifact references (e.g. tags) do not support the plus sign (+). To support
storing semantic versions, Helm adopts the convention of changing plus (+) to
an underscore (_) in chart version tags when pushing to a registry and back to
a plus (+) when pulling from a registry.

I adopted that approach in the metal3/turtles PRs just pushed, but we can test/discuss before aligning here.

We may need to do some testing but do we also want to align the `BuildTag` as helm says: ``` OCI artifact references (e.g. tags) do not support the plus sign (+). To support storing semantic versions, Helm adopts the convention of changing plus (+) to an underscore (_) in chart version tags when pushing to a registry and back to a plus (+) when pulling from a registry. ``` I adopted that approach in the metal3/turtles PRs just pushed, but we can test/discuss before aligning here.
dprodanov force-pushed update-charts-version from 8b133980be to e31fc75572 2024-11-15 14:48:36 +01:00 Compare
dprodanov force-pushed update-charts-version from e31fc75572 to 2fe0c8280a 2024-11-15 15:04:31 +01:00 Compare
dprodanov commented 2024-11-15 15:07:43 +01:00
Author
Owner
Copy Link

I updated this PR following your approach for the BuildTag.

I updated this PR following your approach for the BuildTag.
steven.hardy reviewed 2024-11-15 17:02:35 +01:00
akri-dashboard-extension-chart/Chart.yaml Outdated
@ -1,5 +1,5 @@
#!BuildTag: %%IMG_PREFIX%%akri-dashboard-extension-chart:1.2.0
#!BuildTag: %%IMG_PREFIX%%akri-dashboard-extension-chart:1.2.0-%RELEASE%
#!BuildTag: %%IMG_PREFIX%%akri-dashboard-extension-chart:302.0.0_up1.1.0
#!BuildTag: %%IMG_PREFIX%%akri-dashboard-extension-chart:302.0.0_up1.1.0-%RELEASE%
steven.hardy commented 2024-11-15 17:02:35 +01:00
Owner
Copy Link

This needs rebasing on the version update from @jtomasek

This needs rebasing on the version update from @jtomasek
dprodanov marked this conversation as resolved
steven.hardy reviewed 2024-11-15 17:03:24 +01:00
metal3-chart/Chart.yaml Outdated
@ -16,3 +16,3 @@
name: mariadb
repository: file://./charts/mariadb
version: 0.5.4
version: 302.0.0_up0.5.4
steven.hardy commented 2024-11-15 17:03:24 +01:00
Owner
Copy Link

This is a subchart reference and should not be updated

This is a subchart reference and should not be updated
dprodanov marked this conversation as resolved
steven.hardy reviewed 2024-11-15 17:03:43 +01:00
akri-dashboard-extension-chart/Chart.yaml Outdated
@ -18,3 +18,3 @@
name: akri-dashboard-extension
type: application
version: 1.2.0
version: 302.0.0+up1.1.0
steven.hardy commented 2024-11-15 17:03:43 +01:00
Owner
Copy Link

Same as above, needs updating to 1.2.0

Same as above, needs updating to 1.2.0
dprodanov marked this conversation as resolved
steven.hardy requested changes 2024-11-15 17:04:37 +01:00
Dismissed
steven.hardy left a comment
Owner
Copy Link

Couple of remaining issues, otherwise lgtm

Couple of remaining issues, otherwise lgtm
dprodanov force-pushed update-charts-version from 2fe0c8280a to dfd55917f2 2024-11-18 09:26:02 +01:00 Compare
dprodanov force-pushed update-charts-version from dfd55917f2 to 3543bbe39e 2024-11-18 09:39:57 +01:00 Compare
dprodanov commented 2024-11-18 09:41:10 +01:00
Author
Owner
Copy Link

All issues resolved now.

All issues resolved now.
dprodanov requested review from steven.hardy 2024-11-18 09:41:17 +01:00
nbelouin reviewed 2024-11-18 09:58:56 +01:00
nbelouin left a comment
Owner
Copy Link

LGTM overall, I however think we should have them be some kind of template here to make it easier for us, something like %%CHART_MAJOR%%.X.Y and have OBS to replace it to 302 in the 3.2 branch and say 999 in Factory, this way we don't have to do anything when cutting a new release branch here

LGTM overall, I however think we should have them be some kind of template here to make it easier for us, something like `%%CHART_MAJOR%%.X.Y` and have OBS to replace it to `302` in the 3.2 branch and say `999` in Factory, this way we don't have to do anything when cutting a new release branch here
👍 1
dprodanov force-pushed update-charts-version from 3543bbe39e to a66325901d 2024-11-18 10:53:58 +01:00 Compare
dprodanov requested review from nbelouin 2024-11-18 12:37:20 +01:00
steven.hardy reviewed 2024-11-18 12:39:56 +01:00
akri-dashboard-extension-chart/Chart.yaml
@ -14,3 +14,3 @@
apiVersion: v2
appVersion: 1.2.0
description: 'SUSE Edge: Akri extension for Rancher Dashboard'
description: "SUSE Edge: Akri extension for Rancher Dashboard"
steven.hardy commented 2024-11-18 12:39:56 +01:00
Owner
Copy Link

Not sure why the quoting changed as seems unrelated to the version updates?

Not sure why the quoting changed as seems unrelated to the version updates?
dprodanov commented 2024-11-18 12:55:14 +01:00
Author
Owner
Copy Link

This is caused by my auto formatter. It is set to use double quotes for these types of files.

This is caused by my auto formatter. It is set to use double quotes for these types of files.
dprodanov marked this conversation as resolved
steven.hardy approved these changes 2024-11-18 12:40:15 +01:00
dprodanov merged commit ed9a5df069 into main 2024-11-18 12:55:34 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
nbelouin
steven.hardy
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suse-edge/Factory#14
No description provided.
Delete Branch "update-charts-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?