Update the metal3-chart to fix the IPA ramdisk with multiple config-2 drives #145
Reference in New Issue
Block a user
No description provided.
Delete Branch "mchiappero/Factory:metal3_0.11.1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Correct a bug in the IPA ramdisk, which resulted in the wrong config-2 volume being picked up by NetworkManager when multiple such disks are present on the system (e.g. from previous installation and redfish).
aee375dbb1
to043aaedb4d
@@ -23,4 +23,2 @@
nodeSelector: {}
enable_tls: false
Note for other reviewers - I think this reverts a mistake introduced via
1048591769
- @nbelouin I guess that was from some debugging?Was to solve some issues related to linting, no longer necessary and didn't remove those, so no problem in removing them.
Do we prefer to have a separate PR?
Overall Looks good to me, just need to bump the chart version
@@ -26,3 +26,3 @@
name: metal3
type: application
version: "%%CHART_MAJOR%%.0.2+up0.11.0"
version: "%%CHART_MAJOR%%.0.2+up0.11.1"
Please also bump the chart version itself (the
+up
suffix isn't used for version ordering)043aaedb4d
to1f11000be9
I'm not able to understand why the checks are failing, is it a problem with OBS? Do you have any idea?
1f11000be9
toc2fdf53c4b
Well a merged PR broke sriov chart build, so it makes the checks to fail
c2fdf53c4b
tofbb61edd06
@@ -1,7 +1,7 @@
#!BuildTag: %%CHART_PREFIX%%metal3:%%CHART_MAJOR%%.0.2_up0.11.0
#!BuildTag: %%CHART_PREFIX%%metal3:%%CHART_MAJOR%%.0.2_up0.11.0-%RELEASE%
#!BuildTag: %%CHART_PREFIX%%metal3:%%CHART_MAJOR%%.0.3_up0.11.1
#!BuildTag: %%CHART_PREFIX%%metal3:%%CHART_MAJOR%%.0.3_up0.11.1-%RELEASE%
@nbelouin since this will be the first chart release for 3.3 do we expec this to be
%%CHART_MAJOR%%.0.0
until the release happens?no, we should always bump the last elements here (and not reset them), put simply if we consider Factory (with chart major
999
) as a rolling upgrade like it should work as upgrades when we do changes to charts.Ok thanks for clarifying - it may be worth discussing this with the team to ensure everyone is aware, as this is a different strategy to rancher/charts which resets the version for each rancher release
fbb61edd06
to03e37421d7
It passes now, after the last rebase. Thank you 👍
03e37421d7
toc6b78eb569