suse-edge/Factory
SHA256
11
0
Fork 4
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

update-versions #2

Merged
dprodanov merged 3 commits from update-versions into main 2024-11-07 11:36:44 +01:00
Conversation 1 Commits 3 Files Changed 10 +86 -8
dprodanov commented 2024-11-04 10:52:24 +01:00
Owner
Copy Link
No description provided.
dprodanov added 2 commits 2024-11-04 10:52:24 +01:00
dprodanov added 1 commit 2024-11-04 10:52:40 +01:00
dprodanov force-pushed update-versions from 83015cec20 to ccaa29275d 2024-11-04 12:27:48 +01:00 Compare
steven.hardy commented 2024-11-04 18:25:31 +01:00
Owner
Copy Link

Looks OK to me, I think you can probably drop the merge commit and do e.g git rebase -i origin to rebase this branch on main?

I see now that we already have https://src.opensuse.org/suse-edge/Factory/src/branch/main/openstack-ironic-image - this is probably fine for now but we'll likely want to rename this package in due course since the suffix makes it look like a container image.

In https://build.opensuse.org/project/show/isv:SUSE:Edge:Metal3:Ironic:2024.2 I went with ironic-ipa-ramdisk so we can probably deal with the rename when updating the openstack dependencies and picking up that version (it's not ready yet though).

Looks OK to me, I think you can probably drop the merge commit and do e.g `git rebase -i origin` to rebase this branch on main? I see now that we already have https://src.opensuse.org/suse-edge/Factory/src/branch/main/openstack-ironic-image - this is probably fine for now but we'll likely want to rename this package in due course since the suffix makes it look like a container image. In https://build.opensuse.org/project/show/isv:SUSE:Edge:Metal3:Ironic:2024.2 I went with `ironic-ipa-ramdisk` so we can probably deal with the rename when updating the openstack dependencies and picking up that version (it's not ready yet though).
steven.hardy requested review from nbelouin 2024-11-04 18:25:46 +01:00
steven.hardy requested review from steven.hardy 2024-11-04 18:25:52 +01:00
nbelouin approved these changes 2024-11-07 10:29:14 +01:00
dprodanov merged commit cdd1b27ef6 into main 2024-11-07 11:36:44 +01:00
dprodanov deleted branch update-versions 2024-11-07 11:36:44 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
steven.hardy
nbelouin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suse-edge/Factory#2
No description provided.
Delete Branch "update-versions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?