suse-edge/Factory
SHA256
17
0
Fork 17
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix: Allow helm chart metadata icon to be file #255

Merged
eminguez merged 1 commits from eminguez/suse-edge-factory:pyhelm3-icon-allow-file into main 2025-09-03 13:47:25 +02:00
Conversation 3 Commits 1 Files Changed 2 +43 -1
eminguez commented 2025-09-02 17:34:09 +02:00
Owner
Copy Link
No description provided.
eminguez added 1 commit 2025-09-02 17:34:09 +02:00
fix: Allow helm chart metadata icon to be file
Some checks failed
Check Release Manifest Local Charts Versions / Check Release Manifest Local Charts Versions (pull_request) Successful in 9s
Details
Build PR in OBS / Build PR in OBS (pull_request_target) Failing after 1h15m52s
Details
dae4492411
eminguez requested review from nbelouin 2025-09-02 17:56:06 +02:00
nbelouin approved these changes 2025-09-03 08:23:53 +02:00
nbelouin left a comment
Owner
Copy Link

Not sure this will be the final version of the patch, but it will solve the issue, and it's not a real problem for us if the icon is not well validated, so 👍

Not sure this will be the final version of the patch, but it will solve the issue, and it's not a real problem for us if the icon is not well validated, so 👍
python-pyhelm3/0001-icon-metadata-allow-any-string.patch Outdated
@@ -0,0 +7,4 @@
description = "List of maintainers for the chart."
)
- icon: t.Optional[HttpUrl] = Field(
+ icon: t.Optional[NonEmptyString] = Field(
nbelouin commented 2025-09-03 08:22:16 +02:00
Owner
Copy Link

I think that t.Optional[HttpUrl | FileUrl] would be better then, so it still checks it is a valid url, but it's something to see with pyhelm3 devs.

I think that `t.Optional[HttpUrl | FileUrl]` would be better then, so it still checks it is a valid url, but it's something to see with pyhelm3 devs.
eminguez commented 2025-09-03 11:06:31 +02:00
Author
Owner
Copy Link

That's even better, thanks Nicolas.

That's even better, thanks Nicolas.
eminguez marked this conversation as resolved
eminguez commented 2025-09-03 11:06:47 +02:00
Author
Owner
Copy Link

Just in case, I sent the PR upstream as well https://github.com/azimuth-cloud/pyhelm3/pull/35

Just in case, I sent the PR upstream as well https://github.com/azimuth-cloud/pyhelm3/pull/35
eminguez force-pushed pyhelm3-icon-allow-file from dae4492411 to 8ac6ade850 2025-09-03 11:08:54 +02:00 Compare
eminguez force-pushed pyhelm3-icon-allow-file from 8ac6ade850 to 6e9b62619d 2025-09-03 11:09:47 +02:00 Compare
eminguez requested review from nbelouin 2025-09-03 11:09:56 +02:00
eminguez force-pushed pyhelm3-icon-allow-file from 6e9b62619d to db5c94414c 2025-09-03 12:00:02 +02:00 Compare
eminguez commented 2025-09-03 13:46:59 +02:00
Author
Owner
Copy Link

I think the issues on OBS are related to #256 so I'm going to merge it.

I think the issues on OBS are related to https://src.opensuse.org/suse-edge/Factory/pulls/256 so I'm going to merge it.
eminguez force-pushed pyhelm3-icon-allow-file from db5c94414c to b94d722028 2025-09-03 13:47:10 +02:00 Compare
eminguez merged commit 6d50385ec3 into main 2025-09-03 13:47:25 +02:00
eminguez deleted branch pyhelm3-icon-allow-file 2025-09-03 13:47:26 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
nbelouin
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#255
Delete Branch "eminguez/suse-edge-factory:pyhelm3-icon-allow-file"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?