suse-edge/Factory
SHA256
17
0
Fork 18
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

metal3-chart: Adjust ipxe firmware filename #332

Merged
steven.hardy merged 2 commits from steven.hardy/Factory:metal3_pxe into main 2025-12-17 16:24:09 +01:00
Conversation 3 Commits 2 Files Changed 6 +19 -19
steven.hardy commented 2025-12-16 10:18:30 +01:00
Owner
Copy Link

The dnsmasq configuration expects this to be named snponly.efi - to align with
upstream we can adjust the target filename in the Dockerfile

Fixes: https://github.com/suse-edge/charts/issues/188

The dnsmasq configuration expects this to be named snponly.efi - to align with upstream we can adjust the target filename in the Dockerfile Fixes: https://github.com/suse-edge/charts/issues/188
steven.hardy requested review from nbelouin 2025-12-16 10:18:31 +01:00
nbelouin requested changes 2025-12-16 10:50:55 +01:00
Dismissed
nbelouin left a comment
Owner
Copy Link

Small changes to be more consistent across architectures

Small changes to be more consistent across architectures
ironic-image/Dockerfile Outdated
@@ -88,3 +88,3 @@
#!ArchExclusiveLine: x86_64
RUN if [ "$(uname -m)" = "x86_64" ];then \
cp /usr/share/ipxe/ipxe-x86_64.efi /tftpboot/ipxe.efi ;\
cp /usr/share/ipxe/ipxe-x86_64.efi /tftpboot/snponly.efi ;\
nbelouin commented 2025-12-16 10:47:46 +01:00
Owner
Copy Link

From a quick look we should take /usr/share/ipxe/snp-x86_64.efi rather than ipxe-x86_64.efi as source file.

From a quick look we should take `/usr/share/ipxe/snp-x86_64.efi` rather than `ipxe-x86_64.efi` as source file.
nbelouin marked this conversation as resolved
ironic-image/Dockerfile Outdated
@@ -92,3 +92,3 @@
#!ArchExclusiveLine: aarch64
RUN if [ "$(uname -m)" = "aarch64" ]; then\
cp /usr/share/ipxe/snp-arm64.efi /tftpboot/ipxe.efi; cp /usr/share/ipxe/snp-arm64.efi /tftpboot/snp-arm64.efi; cp /usr/share/ipxe/snp-arm64.efi /tftpboot/snp.efi ;\
cp /usr/share/ipxe/snp-arm64.efi /tftpboot/snponly.efi; cp /usr/share/ipxe/snp-arm64.efi /tftpboot/snp-arm64.efi; cp /usr/share/ipxe/snp-arm64.efi /tftpboot/snp.efi ;\
nbelouin commented 2025-12-16 10:48:50 +01:00
Owner
Copy Link

We don't need the /tftpboot/snp-arm64.efi and /tftpboot/snp.efi copies.

We don't need the `/tftpboot/snp-arm64.efi` and `/tftpboot/snp.efi` copies.
nbelouin marked this conversation as resolved
steven.hardy force-pushed metal3_pxe from ef68897d37 to 92b0df2060 2025-12-16 18:27:34 +01:00 Compare
nbelouin requested changes 2025-12-17 08:29:10 +01:00
Dismissed
nbelouin left a comment
Owner
Copy Link

Need to update release manifest, otherwise good to go

Need to update release manifest, otherwise good to go
steven.hardy added 1 commit 2025-12-17 15:54:07 +01:00
Update release manifest
Some checks failed
Check Release Manifest Local Charts Versions / Check Release Manifest Local Charts Versions (pull_request) Successful in -4s
Details
Build PR in OBS / Build PR in OBS (pull_request_target) Failing after 3h13m5s
Details
676ebb6266
nbelouin approved these changes 2025-12-17 16:06:33 +01:00
steven.hardy merged commit 349fb00a48 into main 2025-12-17 16:24:09 +01:00
steven.hardy deleted branch metal3_pxe 2025-12-17 16:24:09 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
nbelouin
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#332
Delete Branch "steven.hardy/Factory:metal3_pxe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?