suse-edge/Factory
SHA256
14
0
Fork 15
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix metal3 chart #172

Merged
nbelouin merged 2 commits from nbelouin/Factory:metal3-chart-fixes into main 2025-06-04 11:26:59 +02:00
Conversation 2 Commits 2 Files Changed 7 +13 -32
nbelouin commented 2025-06-04 10:18:56 +02:00
Owner
Copy Link

Fix several small issues with the metal3 chart:

  • scope issue leading to error when defining extra annotations for Ironic
  • version mismatch for the Ironic image tag in the media subchart
  • extra unneeded template in bmo subchart that was mistakenly not removed here when removed in upstream chart
Fix several small issues with the metal3 chart: - scope issue leading to error when defining extra annotations for Ironic - version mismatch for the Ironic image tag in the media subchart - extra unneeded template in bmo subchart that was mistakenly not removed here when removed in upstream chart
nbelouin added 1 commit 2025-06-04 10:18:57 +02:00
Fix metal3 chart
Some checks failed
Check Release Manifest Local Charts Versions / Check Release Manifest Local Charts Versions (pull_request) Successful in -1m7s
Details
Build PR in OBS / Build PR in OBS (pull_request_target) Failing after 1h8m23s
Details
74d510ba73 
Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
nbelouin requested review from mchiappero 2025-06-04 10:18:58 +02:00
nbelouin requested review from steven.hardy 2025-06-04 10:18:59 +02:00
nbelouin force-pushed metal3-chart-fixes from 74d510ba73 to ec7da715f4 2025-06-04 10:44:09 +02:00 Compare
mchiappero approved these changes 2025-06-04 10:45:10 +02:00
steven.hardy approved these changes 2025-06-04 10:58:48 +02:00
steven.hardy left a comment
Owner
Copy Link

lgtm, thanks!

lgtm, thanks!
nbelouin merged commit 1f36228510 into main 2025-06-04 11:26:59 +02:00
nbelouin deleted branch metal3-chart-fixes 2025-06-04 11:27:06 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mchiappero
steven.hardy
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jtomasek kzhelyazkov mchiappero nbelouin roxenham steven.hardy
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#172
No description provided.
Delete Branch "nbelouin/Factory:metal3-chart-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?