suse-edge/Factory
SHA256
17
0
Fork 17
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Bump minor version in ironic-image and metal3-chart #206

Merged
mchiappero merged 1 commits from mchiappero/Factory:ironic_26.1.2.5 into main 2025-07-10 23:41:20 +02:00
Conversation 5 Commits 1 Files Changed 7 +15 -15
mchiappero commented 2025-07-08 14:40:10 +02:00
Owner
Copy Link

Update ironic, and as a consequence the metal3 Helm chart, to include
the following changes:

#198
#199
#200
#201
#203
#204

Signed-off-by: Marco Chiappero marco.chiappero@suse.com

Update ironic, and as a consequence the metal3 Helm chart, to include the following changes: https://src.opensuse.org/suse-edge/Factory/pulls/198 https://src.opensuse.org/suse-edge/Factory/pulls/199 https://src.opensuse.org/suse-edge/Factory/pulls/200 https://src.opensuse.org/suse-edge/Factory/pulls/201 https://src.opensuse.org/suse-edge/Factory/pulls/203 https://src.opensuse.org/suse-edge/Factory/pulls/204 Signed-off-by: Marco Chiappero <marco.chiappero@suse.com>
nbelouin approved these changes 2025-07-08 14:41:53 +02:00
mchiappero force-pushed ironic_26.1.2.5 from 25a5ea6db7 to 3244ea3c7f 2025-07-08 14:44:46 +02:00 Compare
mchiappero force-pushed ironic_26.1.2.5 from 3244ea3c7f to 5c19e258ea 2025-07-08 14:49:09 +02:00 Compare
mchiappero reviewed 2025-07-08 14:51:19 +02:00
metal3-chart/Chart.yaml Outdated
@@ -26,3 +26,3 @@
name: metal3
type: application
version: "%%CHART_MAJOR%%.0.8+up0.11.6"
version: "%%CHART_MAJOR%%.0.9+up0.11.7"
mchiappero commented 2025-07-08 14:51:19 +02:00
Author
Owner
Copy Link

@nbelouin, just to double check: we need to update both major and minor, correct?

@nbelouin, just to double check: we need to update both major and minor, correct?
nbelouin commented 2025-07-08 14:57:13 +02:00
Owner
Copy Link

we need to update both the chart version comparable version i.e %%CHART_MAJOR%%.0.8 -> %%CHART_MAJOR%%.0.9 and the +up suffix one up0.11.6 -> up0.11.7.
About what component of the version we bump, I think it's fine with just bumping patch here

we need to update both the chart version comparable version i.e `%%CHART_MAJOR%%.0.8 -> %%CHART_MAJOR%%.0.9` and the `+up` suffix one `up0.11.6 -> up0.11.7`. About what component of the version we bump, I think it's fine with just bumping patch here
mchiappero commented 2025-07-08 14:59:52 +02:00
Author
Owner
Copy Link

Thank you for your comment, initially I thought it was ok just to go with the minor, but then I remembered about a previous comment you made a while ago... I'll revert then.

Thank you for your comment, initially I thought it was ok just to go with the minor, but then I remembered about a previous comment you made a while ago... I'll revert then.
nbelouin commented 2025-07-09 09:09:14 +02:00
Owner
Copy Link

Okay probably got misunderstood here, you still need to bump %%CHART_MAJOR%%.0.8 (the comparable version).

Simply put, semver tells that everything after the + is basically just some informative stuff that doesn't impact the ordering of versions (i.e some kind of comment).

Okay probably got misunderstood here, you still need to bump `%%CHART_MAJOR%%.0.8` (the comparable version). Simply put, semver tells that everything after the `+` is basically just some informative stuff that doesn't impact the ordering of versions (i.e some kind of comment).
mchiappero commented 2025-07-09 11:05:28 +02:00
Author
Owner
Copy Link

Sorry, some wrong wording from my side, using the "+up...." token as "minor".
Let me update again.

Sorry, some wrong wording from my side, using the "+up...." token as "minor". Let me update again.
mchiappero changed title from WIP: Bump minor version in ironic-image and metal3-chart to Bump minor version in ironic-image and metal3-chart 2025-07-08 14:51:38 +02:00
mchiappero force-pushed ironic_26.1.2.5 from 5c19e258ea to 3244ea3c7f 2025-07-08 15:04:25 +02:00 Compare
mchiappero requested review from amorgante 2025-07-08 16:28:49 +02:00
mchiappero requested review from steven.hardy 2025-07-08 16:28:50 +02:00
mchiappero commented 2025-07-09 08:18:37 +02:00
Author
Owner
Copy Link

Let's maybe merge #207 first...

Let's maybe merge #207 first...
mchiappero force-pushed ironic_26.1.2.5 from 3244ea3c7f to 4f830863f9 2025-07-09 11:12:53 +02:00 Compare
mchiappero commented 2025-07-09 14:29:08 +02:00
Author
Owner
Copy Link

I think #207 broke something... let me trace the problem first.

I think #207 broke something... let me trace the problem first.
mchiappero changed title from Bump minor version in ironic-image and metal3-chart to WIP: Bump minor version in ironic-image and metal3-chart 2025-07-09 14:29:41 +02:00
mchiappero force-pushed ironic_26.1.2.5 from 4f830863f9 to 7c001b591d 2025-07-10 22:16:56 +02:00 Compare
mchiappero commented 2025-07-10 22:19:20 +02:00
Author
Owner
Copy Link

I think #207 broke something... let me trace the problem first.

The problem was something else.

> I think #207 broke something... let me trace the problem first. The problem was something else.
mchiappero changed title from WIP: Bump minor version in ironic-image and metal3-chart to Bump minor version in ironic-image and metal3-chart 2025-07-10 22:28:28 +02:00
mchiappero force-pushed ironic_26.1.2.5 from 7c001b591d to f23003c01f 2025-07-10 22:32:59 +02:00 Compare
mchiappero merged commit f23003c01f into main 2025-07-10 23:41:20 +02:00
mchiappero deleted branch ironic_26.1.2.5 2025-07-10 23:41:21 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
nbelouin
mchiappero
amorgante
steven.hardy
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#206
Delete Branch "mchiappero/Factory:ironic_26.1.2.5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?