suse-edge/Factory
SHA256
17
0
Fork 18
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Allow to set IRONIC_EXTERNAL_URL_V6 to Metal3 BMO #241

Merged
mchiappero merged 2 commits from mchiappero/Factory:metal3-external-v6 into main 2025-09-01 16:08:45 +02:00
Conversation 7 Commits 2 Files Changed 5 +16 -7
mchiappero commented 2025-08-19 18:48:54 +02:00
Owner
Copy Link

Whenever a BMC only has an IPv6 address, the Baremetal Operator will
change the "external_http_url" in the driver to an IPv6 contained in
IRONIC_EXTERNAL_URL_V6, if set.

Introduce 'externalHttpIPv6' in values for the BMO, in order to generate
such environment variable in configmap-ironic.yaml.

Signed-off-by: Marco Chiappero marco.chiappero@suse.com

Whenever a BMC only has an IPv6 address, the Baremetal Operator will change the "external_http_url" in the driver to an IPv6 contained in IRONIC_EXTERNAL_URL_V6, if set. Introduce 'externalHttpIPv6' in values for the BMO, in order to generate such environment variable in configmap-ironic.yaml. Signed-off-by: Marco Chiappero <marco.chiappero@suse.com>
mchiappero changed title from Allow to set IRONIC_EXTERNAL_URL_V6 to Metal3 BMO to WIP: Allow to set IRONIC_EXTERNAL_URL_V6 to Metal3 BMO 2025-08-19 18:49:06 +02:00
mchiappero commented 2025-08-19 18:50:42 +02:00
Author
Owner
Copy Link

I'm setting WIP, not because it's not ready, but because I want to test it first, as I would like to double check the assumption for the provisioning network is to be dual-stack (that is able to use IPv4).

I'm setting WIP, not because it's not ready, but because I want to test it first, as I would like to double check the assumption for the provisioning network is to be dual-stack (that is able to use IPv4).
mchiappero commented 2025-08-21 16:10:41 +02:00
Author
Owner
Copy Link

Seems to be working:

[Thu Aug 21 13:55:27.883572 2025] [ssl:debug] [pid 39:tid 39] ssl_engine_io.c(1154): [client 193.168.0.183:60332] AH02001: Connection closed to child 6 with standard shutdown (server 127.0.0.1:6385)
2a07:de40:a102:7:b645:6ff:feed:1289 - - [21/Aug/2025:13:55:29 +0000] "GET /redfish/boot-df55dde6-a8ed-4152-ad76-547d6fd8cf10.iso HTTP/1.1" 206 4096 "-" "libcurl-agent/1.0"
2a07:de40:a102:7:b645:6ff:feed:1289 - - [21/Aug/2025:13:55:29 +0000] "GET /redfish/boot-df55dde6-a8ed-4152-ad76-547d6fd8cf10.iso HTTP/1.1" 206 2048 "-" "libcurl-agent/1.0"
2a07:de40:a102:7:b645:6ff:feed:1289 - - [21/Aug/2025:13:55:29 +0000] "GET /redfish/boot-df55dde6-a8ed-4152-ad76-547d6fd8cf10.iso HTTP/1.1" 206 4096 "-" "libcurl-agent/1.0"

Will now rebase.

Seems to be working: > [Thu Aug 21 13:55:27.883572 2025] [ssl:debug] [pid 39:tid 39] ssl_engine_io.c(1154): [client 193.168.0.183:60332] AH02001: Connection closed to child 6 with standard shutdown (server 127.0.0.1:6385) > 2a07:de40:a102:7:b645:6ff:feed:1289 - - [21/Aug/2025:13:55:29 +0000] "GET /redfish/boot-df55dde6-a8ed-4152-ad76-547d6fd8cf10.iso HTTP/1.1" 206 4096 "-" "libcurl-agent/1.0" > 2a07:de40:a102:7:b645:6ff:feed:1289 - - [21/Aug/2025:13:55:29 +0000] "GET /redfish/boot-df55dde6-a8ed-4152-ad76-547d6fd8cf10.iso HTTP/1.1" 206 2048 "-" "libcurl-agent/1.0" > 2a07:de40:a102:7:b645:6ff:feed:1289 - - [21/Aug/2025:13:55:29 +0000] "GET /redfish/boot-df55dde6-a8ed-4152-ad76-547d6fd8cf10.iso HTTP/1.1" 206 4096 "-" "libcurl-agent/1.0" Will now rebase.
mchiappero force-pushed metal3-external-v6 from d743aca36a to 9606b3936c 2025-08-21 16:18:36 +02:00 Compare
mchiappero changed title from WIP: Allow to set IRONIC_EXTERNAL_URL_V6 to Metal3 BMO to Allow to set IRONIC_EXTERNAL_URL_V6 to Metal3 BMO 2025-08-21 16:19:19 +02:00
mchiappero requested review from nbelouin 2025-08-21 16:19:28 +02:00
mchiappero requested review from steven.hardy 2025-08-21 16:19:28 +02:00
nbelouin approved these changes 2025-08-21 16:54:24 +02:00
Dismissed
nbelouin left a comment
Owner
Copy Link

LGTM
I guess we're are trying to bundle multiple changes at once, hence no version bumps ?

LGTM I guess we're are trying to bundle multiple changes at once, hence no version bumps ?
mchiappero commented 2025-08-21 18:04:17 +02:00
Author
Owner
Copy Link

LGTM
I guess we're are trying to bundle multiple changes at once, hence no version bumps ?

I've completely forgotten about it, sorry. Let me add a commit.

> LGTM > I guess we're are trying to bundle multiple changes at once, hence no version bumps ? I've completely forgotten about it, sorry. Let me add a commit.
nbelouin approved these changes 2025-08-22 15:27:25 +02:00
Dismissed
mchiappero force-pushed metal3-external-v6 from 212162515f to 9cbf868ba7 2025-09-01 14:54:46 +02:00 Compare
mchiappero commented 2025-09-01 14:58:42 +02:00
Author
Owner
Copy Link

Same code, just rebased and bumped the versions again.

Same code, just rebased and bumped the versions again.
nbelouin approved these changes 2025-09-01 16:07:45 +02:00
mchiappero merged commit 9cbf868ba7 into main 2025-09-01 16:08:45 +02:00
mchiappero deleted branch metal3-external-v6 2025-09-01 16:08:45 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
steven.hardy
nbelouin
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#241
Delete Branch "mchiappero/Factory:metal3-external-v6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?