suse-edge/Factory
SHA256
17
0
Fork 18
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

rancher-turtles-providers: fix ClusterctlConfig syntax #328

Merged
steven.hardy merged 1 commits from steven.hardy/Factory:turtles_providers_fix into main 2025-12-11 09:43:38 +01:00
Conversation 3 Commits 1 Files Changed 2 +9 -9
steven.hardy commented 2025-12-10 09:56:01 +01:00
Owner
Copy Link

The current syntax is wrong and causes a warning when the CRD is applied

The current syntax is wrong and causes a warning when the CRD is applied
steven.hardy requested review from kzhelyazkov 2025-12-10 09:56:02 +01:00
nbelouin requested changes 2025-12-10 13:47:42 +01:00
Dismissed
rancher-turtles-providers-chart/templates/infrastructure-metal3.yaml Outdated
@@ -28,3 +25,1 @@
repository: "registry.suse.com/rancher"
addon-fleet:
repository: "registry.suse.com/rancher"
- name: control-plane-rke2:
nbelouin commented 2025-12-10 13:47:34 +01:00
Owner
Copy Link

there are extra : on each name: line

there are extra `:` on each `name:` line
steven.hardy commented 2025-12-10 14:22:59 +01:00
Author
Owner
Copy Link

oops, now fixed!

oops, now fixed!
steven.hardy marked this conversation as resolved
steven.hardy added 1 commit 2025-12-10 14:22:13 +01:00
rancher-turtles-providers: fix ClusterctlConfig syntax
All checks were successful
Check Release Manifest Local Charts Versions / Check Release Manifest Local Charts Versions (pull_request) Successful in 9s
Details
Build PR in OBS / Build PR in OBS (pull_request_target) Successful in 8s
Details
2daf7e1d46 
The current syntax is wrong and causes a warning when the CRD is applied
kzhelyazkov approved these changes 2025-12-10 16:24:22 +01:00
kzhelyazkov left a comment
Owner
Copy Link

LGTM

Tested with SV

LGTM Tested with SV
nbelouin approved these changes 2025-12-10 16:25:23 +01:00
steven.hardy merged commit 2daf7e1d46 into main 2025-12-11 09:43:38 +01:00
steven.hardy deleted branch turtles_providers_fix 2025-12-11 09:43:39 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
kzhelyazkov
nbelouin
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#328
Delete Branch "steven.hardy/Factory:turtles_providers_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?