suse-edge/Factory
SHA256
17
0
Fork 18
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

[3.5] Merge pull request 'fix-release-manifests-appsco' (#374) #375

Open
amorgante wants to merge 1 commits from amorgante-patch-1 into 3.5
pull from: amorgante-patch-1
merge into: suse-edge:3.5
Conversation 3 Commits 1 Files Changed 1 +1 -2
amorgante commented 2026-01-29 15:22:51 +01:00
Owner
Copy Link

Reviewed-on: #374
Reviewed-by: Nicolas Belouin nbelouin@noreply.src.opensuse.org

Reviewed-on: https://src.opensuse.org/suse-edge/Factory/pulls/374 Reviewed-by: Nicolas Belouin <nbelouin@noreply.src.opensuse.org>
amorgante added 1 commit 2026-01-29 15:22:51 +01:00
Merge pull request 'fix-release-manifests-appsco' (#374)
Some checks failed
Check Release Manifest Local Charts Versions / Check Release Manifest Local Charts Versions (pull_request) Successful in -34s
Details
Build PR in OBS / Build PR in OBS (pull_request_target) Failing after -33s
Details
f94144b969 
Reviewed-on: #374
Reviewed-by: Nicolas Belouin <nbelouin@noreply.src.opensuse.org>
amorgante requested review from nbelouin 2026-01-29 15:23:13 +01:00
amorgante requested review from steven.hardy 2026-01-29 15:23:13 +01:00
amorgante requested review from dprodanov 2026-01-29 15:23:23 +01:00
steven.hardy changed title from Merge pull request 'fix-release-manifests-appsco' (#374) to [3.5] Merge pull request 'fix-release-manifests-appsco' (#374) 2026-01-29 16:06:42 +01:00
nbelouin approved these changes 2026-01-30 16:50:30 +01:00
steven.hardy commented 2026-02-20 15:11:26 +01:00
Owner
Copy Link

@amorgante in future please can you use a personal fork instead of branching the main repo? Thanks!

Regarding the change, I think it's fine to change for 3.5.1 but not the already released 3.5.0 - so perhaps we can bump the version now to make that clear?

@amorgante in future please can you use a personal fork instead of branching the main repo? Thanks! Regarding the change, I think it's fine to change for 3.5.1 but not the already released 3.5.0 - so perhaps we can bump the version now to make that clear?
nbelouin commented 2026-02-20 15:18:26 +01:00
Owner
Copy Link

We don't re-release without changing the version, it's usually part of the release process (so for 3.5.1) to bump that number at this point, it can be done before though, but merging this won't change the released 3.5.0 manifest.

BTW, @amorgante I noticed this on main branch, but the ' around the uri are not needed and will get removed by the pre-commit hook at some point (it got removed on main branch with #383)

We don't re-release without changing the version, it's usually part of the release process (so for 3.5.1) to bump that number at this point, it can be done before though, but merging this won't change the released 3.5.0 manifest. BTW, @amorgante I noticed this on main branch, but the `'` around the uri are not needed and will get removed by the pre-commit hook at some point (it got removed on main branch with #383)
Some checks failed
Check Release Manifest Local Charts Versions / Check Release Manifest Local Charts Versions (pull_request) Successful in -34s
Details
Build PR in OBS / Build PR in OBS (pull_request_target) Failing after -33s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin amorgante-patch-1:amorgante-patch-1
git checkout amorgante-patch-1
Sign in to join this conversation.
Reviewers
No Reviewers
steven.hardy
dprodanov
nbelouin
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#375
Delete Branch "amorgante-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?