suse-edge/Factory
SHA256
17
0
Fork 17
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Update MetalLB and all other packages around it #98

Merged
kzhelyazkov merged 1 commits from kzhelyazkov/Factory:update-metallb into main 2025-03-20 13:25:13 +01:00
Conversation 4 Commits 1 Files Changed 32 +246 -109
kzhelyazkov commented 2025-03-19 16:41:09 +01:00
Owner
Copy Link

Align MetalLB with https://github.com/suse-edge/charts/pull/194

Align MetalLB with https://github.com/suse-edge/charts/pull/194
kzhelyazkov requested review from steven.hardy 2025-03-19 16:41:32 +01:00
kzhelyazkov requested review from Owners 2025-03-19 16:41:32 +01:00
kzhelyazkov requested review from dprodanov 2025-03-19 16:41:41 +01:00
kzhelyazkov force-pushed update-metallb from e4b1b65e1d to a2e9cf9401 2025-03-19 17:19:28 +01:00 Compare
kzhelyazkov force-pushed update-metallb from a2e9cf9401 to 8dadf2a05b 2025-03-19 17:25:18 +01:00 Compare
kzhelyazkov reviewed 2025-03-19 17:30:25 +01:00
metallb-chart/charts/frr-k8s/values.yaml Outdated
@@ -162,15 +161,17 @@ frrk8s:
frr:
image:
repository: "registry.opensuse.org/isv/suse/edge/metallb/images/frr"
kzhelyazkov commented 2025-03-19 17:30:25 +01:00
Author
Owner
Copy Link

I think those should be overwritten as well, right?

I think those should be overwritten as well, right?
kzhelyazkov marked this conversation as resolved
kzhelyazkov force-pushed update-metallb from 8dadf2a05b to 0f88f8249d 2025-03-19 17:42:34 +01:00 Compare
kzhelyazkov force-pushed update-metallb from 0f88f8249d to 54c0850acf 2025-03-19 17:52:46 +01:00 Compare
dprodanov approved these changes 2025-03-19 18:18:05 +01:00
steven.hardy reviewed 2025-03-20 10:17:53 +01:00
metallb-chart/Chart.yaml
@@ -2,3 +1,2 @@
#!BuildTag: %%IMG_PREFIX%%metallb-chart:%%CHART_MAJOR%%.0.0_up0.14.9-%RELEASE%
apiVersion: v2
appVersion: v0.14.3
appVersion: v0.14.9
steven.hardy commented 2025-03-20 10:17:53 +01:00
Owner
Copy Link

If we backport this to 3.2 we'll need to bump one of the %%CHART_MAJOR%%.0.0 versions - but since this is unreleased I guess it's OK to just align the actual version with the existing tag, and rely on the chart image namepacing for the 3.3 version

If we backport this to 3.2 we'll need to bump one of the `%%CHART_MAJOR%%.0.0` versions - but since this is unreleased I guess it's OK to just align the actual version with the existing tag, and rely on the chart image namepacing for the 3.3 version
👍 1
kzhelyazkov marked this conversation as resolved
steven.hardy approved these changes 2025-03-20 10:19:34 +01:00
steven.hardy left a comment
Owner
Copy Link

In future I would prefer the image/package changes to be separated from the chart update - this makes it much easier to review (and backport/rebase if needed) - otherwise lgtm!

In future I would prefer the image/package changes to be separated from the chart update - this makes it much easier to review (and backport/rebase if needed) - otherwise lgtm!
👍 1
kzhelyazkov merged commit b30ece6b61 into main 2025-03-20 13:25:13 +01:00
kzhelyazkov deleted branch update-metallb 2025-03-20 13:25:14 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
kzhelyazkov
dprodanov
steven.hardy
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#98
Delete Branch "kzhelyazkov/Factory:update-metallb"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?