Accepting request 890332 from devel:languages:tcl

OBS-URL: https://build.opensuse.org/request/show/890332
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/expect?expand=0&rev=29

expect.changes

@@ -1,3 +1,21 @@
+-------------------------------------------------------------------
+Tue May  4 11:02:42 UTC 2021 - Matthias Gerstner <matthias.gerstner@suse.com>
+
+- fix previous change regarding PIE linking. Passing SHLIB_CFLAGS="-shared"
+  causes /usr/bin/expect to become a shared library that SEGFAULTs upon
+  execution. Instead use SHLIB_LD to pass -shared only to shared library
+  linking.
+
+-------------------------------------------------------------------
+Wed Apr 21 13:13:28 UTC 2021 - Matthias Gerstner <matthias.gerstner@suse.com>
+
+- pass explicit -pie flag to CFLAGS and hack `make` invocation so that
+  /usr/bin/expect actually becomes a PIE binary. This is especially awkard
+  since the expect build system implicitly passes -fPIC which breaks our
+  gcc-PIE package, but does not pass -pie while linking the executable.
+  Shared libraries are also not linked with -shared so we need to explicitly
+  pass this, too, to avoid build breakage (bsc#1184122).
+
 -------------------------------------------------------------------
 Thu Oct 15 08:18:32 UTC 2020 - Reinhard Max <max@suse.com>
 

expect.spec

@@ -1,7 +1,7 @@
 #
 # spec file for package expect
 #
-# Copyright (c) 2020 SUSE LLC
+# Copyright (c) 2021 SUSE LLC
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -59,13 +59,14 @@ expect package loaded.
 %patch4
 
 %build
+export CFLAGS="%{optflags} -fPIC -pie"
 autoreconf
 %configure \
 	--with-tcl=%_libdir \
 	--with-tk=no_tk \
 	--with-tclinclude=%_includedir \
 	--enable-shared
-make %{?_smp_mflags} all pkglibdir=%_libdir/tcl/%name%version
+make SHLIB_LD="gcc -shared" %{?_smp_mflags} all pkglibdir=%_libdir/tcl/%name%version
 
 %check
 make %{?_smp_mflags} test