SHA256
1
0
forked from pool/mcelog
Files
mcelog/fix_setgroups_missing_call.patch
Thomas Renninger 169ca77588 - Remove last change to revert AMD patchset (bsc#1249588)
A    Start-consolidating-AMD-specific-stuff.patch
A    add_new_amd_cpu_defines
A    add-f10h-support.patch
A    add-f11h-support.patch
A    add-f12h-support.patch
A    add-f14h-support.patch
A    add-f15h-support.patch
A    add-f16h-support.patch

OBS-URL: https://build.opensuse.org/package/show/Base:System/mcelog?expand=0&rev=122
2025-09-23 07:11:03 +00:00

30 lines
838 B
Diff

---
mcelog.c | 9 +++++++++
1 file changed, 9 insertions(+)
--- a/mcelog.c
+++ b/mcelog.c
@@ -37,6 +37,7 @@
#include <assert.h>
#include <signal.h>
#include <pwd.h>
+#include <grp.h>
#include <sys/wait.h>
#include <fnmatch.h>
#include "mcelog.h"
@@ -1169,6 +1170,14 @@
static void drop_cred(void)
{
+ /* When dropping privileges from root, the `setgroups` call will
+ * remove any extraneous groups. If we don't call this, then
+ * even though our uid has dropped, we may still have groups
+ * that enable us to do super-user things. This will fail if we
+ * aren't root, so don't bother checking the return value, this
+ * is just done as an optimistic privilege dropping function.
+ */
+ setgroups(0, NULL);
if (runcred.uid != -1U && runcred.gid == -1U) {
struct passwd *pw = getpwuid(runcred.uid);
if (pw)