xmpp/profanity
SHA256
4
0
Fork 0
forked from pool/profanity
Code Pull Requests Activity

WIP: general spec file rework #1

Closed
AndreasStieger wants to merge 2 commits from (deleted):gpgme into main
pull from: (deleted):gpgme
merge into: xmpp:main
Conversation 1 Commits 2 Files Changed 4 +258 -100
AndreasStieger commented 2025-07-22 23:51:10 +02:00
Contributor
Copy Link
  • reworked spec file to wrap bcond around optional dependencies
  • split the library and -devel packages
  • enable xscreensaver awareness, use gtk3
  • run some tests
  • package the license files
- reworked spec file to wrap bcond around optional dependencies - split the library and -devel packages - enable xscreensaver awareness, use gtk3 - run some tests - package the license files
autogits-devel requested review from jubalh 2025-07-22 23:51:20 +02:00
jubalh requested changes 2025-07-28 11:37:48 +02:00
jubalh left a comment
Owner
Copy Link

Do you maybe also want to address boo#1246851 in this PR?

Do you maybe also want to address boo#1246851 in this PR?
profanity-rpmlintrc Outdated
@@ -1,6 +0,0 @@
# We created the-mini and -standard packages.
jubalh commented 2025-07-28 11:37:06 +02:00
Owner
Copy Link

I'm not really sure we need to split this out in a own lib if its only used by profanity.

I'm not really sure we need to split this out in a own lib if its only used by profanity.
AndreasStieger commented 2025-07-28 17:39:19 +02:00
Author
Contributor
Copy Link

Yes this will address boo#1246851 when done.

I understand that the library is for the plug-ins. So if we split the lib then the plugins can be built with a reduced dependency set, and specifically without also having the client installed.

Yes this will address boo#1246851 when done. I understand that the library is for the plug-ins. So if we split the lib then the plugins can be built with a reduced dependency set, and specifically without also having the client installed.
profanity.spec Outdated
@@ -19,0 +22,4 @@
%bcond_without python
%bcond_without otr
# boo#1246850
%bcond_with gpg
jubalh commented 2025-07-28 11:37:38 +02:00
Owner
Copy Link

disable gpg support boo#1246850 isn't necessary anymore.

`disable gpg support boo#1246850` isn't necessary anymore.
AndreasStieger commented 2025-07-28 17:23:13 +02:00
Author
Contributor
Copy Link

yes I saw the parallel change

yes I saw the parallel change
AndreasStieger marked this conversation as resolved
AndreasStieger force-pushed gpgme from e48e567ee2 to 9ebfd960b7 2025-07-28 17:21:56 +02:00 Compare
autogits-devel requested review from jubalh 2025-07-28 17:22:04 +02:00
AndreasStieger force-pushed gpgme from 9ebfd960b7 to 53981386b1 2025-07-28 18:57:26 +02:00 Compare
AndreasStieger closed this pull request 2025-08-16 12:42:06 +02:00
AndreasStieger deleted branch gpgme 2025-08-16 12:42:06 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
jubalh
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adamm_super autogits-devel fstrba jubalh
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xmpp/profanity#1
Delete Branch "(deleted):gpgme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?