yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
openSUSE-release-tools/tests/factory_source_tests.py

297 lines
12 KiB
Python
Raw Normal View History

new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
import os
import unittest
import logging
import httpretty
import osc
import re
Provide cache for expensive and cache-able staging requests. The two slowest staging API calls are for information that rarely changes. By caching the result the commands typically execute over twice as fast. Going further can see improvements of an order of magnitude or more by caching almost all the GET requests. In contrast to osclib/memoize.py this cache operates at the HTTP request level. This has several advantages: - Caches the expensive part (ie the HTTP request). There are a number of functions in osc.core and elsewhere that make the same API request, but process the result differently which would require multiple API calls using memoize. - Handles cases were a loader function uses class attributes as input and output and thus no relevant method parameters or return. An important example is StagingAPI._generate_ring_packages(). - Storage is project aware which allows caches to be deleted when a project is known to have changed. - Due to project awareness, can utilize OBS /statistics/latest_updated API call to determine which projects need to be expired. The cache file structure is as follows: - hostname(apiurl) - project - sha1(url) - sha1(url) See Cache.PATTERNS for changing the time to live (ttl) or add patterns to be cached.
2017-01-09 21:49:50 -06:00
from osclib.cache import Cache
do not use oscrc from fixtures (should fix #1989)
2021-09-03 15:33:09 +02:00
from . import OBSLocal
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
Fix httpretty using tests Looks like OSC in Tumbleweed changed behaviour of internal functions
2020-05-02 10:50:33 +02:00
from urllib.parse import urlparse, parse_qs
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
from check_source_in_factory import FactorySourceChecker
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
APIURL = 'http://testhost.example.com'
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
FIXTURES = os.path.join(os.getcwd(), 'tests/fixtures')
do not use oscrc from fixtures (should fix #1989)
2021-09-03 15:33:09 +02:00
class TestFactorySourceAccept(OBSLocal.TestCase):
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
Python3 fixes
2019-05-02 20:34:21 +02:00
def tearDown(self):
httpretty.disable()
httpretty.reset()
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
def setUp(self):
"""
Initialize the configuration
"""
do not use oscrc from fixtures (should fix #1989)
2021-09-03 15:33:09 +02:00
super().setUp()
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
Provide cache for expensive and cache-able staging requests. The two slowest staging API calls are for information that rarely changes. By caching the result the commands typically execute over twice as fast. Going further can see improvements of an order of magnitude or more by caching almost all the GET requests. In contrast to osclib/memoize.py this cache operates at the HTTP request level. This has several advantages: - Caches the expensive part (ie the HTTP request). There are a number of functions in osc.core and elsewhere that make the same API request, but process the result differently which would require multiple API calls using memoize. - Handles cases were a loader function uses class attributes as input and output and thus no relevant method parameters or return. An important example is StagingAPI._generate_ring_packages(). - Storage is project aware which allows caches to be deleted when a project is known to have changed. - Due to project awareness, can utilize OBS /statistics/latest_updated API call to determine which projects need to be expired. The cache file structure is as follows: - hostname(apiurl) - project - sha1(url) - sha1(url) See Cache.PATTERNS for changing the time to live (ttl) or add patterns to be cached.
2017-01-09 21:49:50 -06:00
Cache.last_updated[APIURL] = {'__oldest': '2016-12-18T11:49:37Z'}
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
httpretty.reset()
Fix httpretty using tests Looks like OSC in Tumbleweed changed behaviour of internal functions
2020-05-02 10:50:33 +02:00
httpretty.enable(allow_net_connect=False)
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
logging.basicConfig()
self.logger = logging.getLogger(__file__)
self.logger.setLevel(logging.DEBUG)
More flake8 cleanups
2019-12-10 12:41:11 +01:00
self.checker = FactorySourceChecker(apiurl = APIURL,
user = 'factory-source',
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
logger = self.logger)
Target E261 - two spaces before inline comment
2022-02-18 16:39:16 +01:00
self.checker.override_allow = False # Test setup cannot handle.
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
def test_accept_request(self):
leaper: adjust for SLE 15SP1 and SLE12SP4
2018-06-26 15:18:55 +02:00
httpretty.register_uri(httpretty.GET,
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
APIURL + '/source/openSUSE:Factory/00Meta/lookup.yml',
leaper: adjust for SLE 15SP1 and SLE12SP4
2018-06-26 15:18:55 +02:00
status = 404)
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
httpretty.register_uri(httpretty.GET,
APIURL + "/request/770001",
body = """
tests: add missing creator attribute to requests to satisfy osc.
2017-04-13 15:08:15 -05:00
<request id="770001" creator="chameleon">
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
<action type="submit">
<source project="Base:System" package="timezone" rev="481ecbe0dfc63ece3a1f1b5598f7d96c"/>
<target project="openSUSE:13.2" package="timezone"/>
</action>
<state name="new" who="factory-source" when="2014-10-08T12:06:07">
<comment>...</comment>
</state>
<review state="new" by_user="factory-source"/>
<description>...</description>
</request>
""")
httpretty.register_uri(httpretty.GET,
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
APIURL + "/source/Base:System/timezone?view=info&rev=481ecbe0dfc63ece3a1f1b5598f7d96c",
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
match_querystring = True,
body = """
<sourceinfo package="timezone"
rev="481ecbe0dfc63ece3a1f1b5598f7d96c"
srcmd5="481ecbe0dfc63ece3a1f1b5598f7d96c"
verifymd5="67bac34d29d70553239d33aaf92d2fdd">
<filename>timezone.spec</filename>
</sourceinfo>
""")
Fix httpretty using tests Looks like OSC in Tumbleweed changed behaviour of internal functions
2020-05-02 10:50:33 +02:00
httpretty.register_uri(httpretty.GET,
APIURL + "/source/openSUSE:Factory/timezone/_meta",
body = """
<package name="timezone" project="openSUSE:Factory">
<title>timezone</title>
<description></description>
</package>
""")
httpretty.register_uri(httpretty.GET,
APIURL + "/source/Base:System/timezone/_meta",
body = """
<package name="timezone" project="Base:System">
<title>timezone</title>
<description></description>
</package>
""")
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
httpretty.register_uri(httpretty.GET,
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
APIURL + "/source/openSUSE:Factory/timezone?view=info",
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
match_querystring = True,
body = """
<sourceinfo package="timezone"
rev="89"
vrev="1"
srcmd5="a36605617cbeefa8168bf0ccf3058074"
verifymd5="a36605617cbeefa8168bf0ccf3058074">
<filename>timezone.spec</filename>
</sourceinfo>
""")
httpretty.register_uri(httpretty.GET,
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
APIURL + "/source/openSUSE:Factory/timezone/_history?limit=5",
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
match_querystring = True,
body = """
<sourceinfo package="timezone"
rev="89"
vrev="1"
srcmd5="a36605617cbeefa8168bf0ccf3058074"
verifymd5="a36605617cbeefa8168bf0ccf3058074">
<filename>timezone.spec</filename>
</sourceinfo>
""")
Python3 fixes
2019-05-02 20:34:21 +02:00
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
httpretty.register_uri(httpretty.GET,
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
APIURL + '/search/request',
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
responses = [
httpretty.Response( body = """
<collection matches="1">
tests: add missing creator attribute to requests to satisfy osc.
2017-04-13 15:08:15 -05:00
<request id="254684" creator="chameleon">
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
<action type="submit">
<source project="Base:System" package="timezone" rev="481ecbe0dfc63ece3a1f1b5598f7d96c"/>
<target project="openSUSE:Factory" package="timezone"/>
</action>
<state name="review" who="factory-auto" when="2014-10-08T11:55:56">
<comment>...</comment>
</state>
Accept requests that are only stuck in Factory staging If only the review by a factory staging project is left in state new and all others are in state accepted it means legal, opensuse-review team etc have completed. So it's safe to consider such a request accepted for inclusion into Factory. So let's not waste time waiting for the next Factory checkin round.
2016-08-19 10:17:06 +02:00
<review state="new" by_group="opensuse-review-team">
<comment/>
</review>
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
<description> ... </description>
</request>
</collection>
"""),
httpretty.Response( body = """
<collection matches="1">
tests: add missing creator attribute to requests to satisfy osc.
2017-04-13 15:08:15 -05:00
<request id="254684" creator="chameleon">
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
<action type="submit">
<source project="Base:System" package="timezone" rev="481ecbe0dfc63ece3a1f1b5598f7d96c"/>
<target project="openSUSE:Factory" package="timezone"/>
</action>
<state name="new" who="factory-auto" when="2014-10-08T11:55:56">
<comment>...</comment>
</state>
<description> ... </description>
</request>
</collection>
""")
Targeting E123 - Closing bracket does not match indentation https://www.flake8rules.com/rules/E123.html
2022-02-18 14:10:20 +01:00
])
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
Fix E203 This fixes incorrect whitespacing inside dictionaries.
2019-12-10 08:54:32 +01:00
result = { 'status': None }
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
def change_request(result, method, uri, headers):
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
query = parse_qs(urlparse(uri).query)
if query == {'by_user': ['factory-source'], 'cmd': ['changereviewstate'], 'newstate': ['accepted']}:
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
result['status'] = True
Accept requests that are only stuck in Factory staging If only the review by a factory staging project is left in state new and all others are in state accepted it means legal, opensuse-review team etc have completed. So it's safe to consider such a request accepted for inclusion into Factory. So let's not waste time waiting for the next Factory checkin round.
2016-08-19 10:17:06 +02:00
else:
result['status'] = 'ERROR'
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
return (200, headers, '<status code="blah"/>')
httpretty.register_uri(httpretty.POST,
APIURL + "/request/770001",
body = lambda method, uri, headers: change_request(result, method, uri, headers))
# first time request is in in review
self.checker.set_request_ids(['770001'])
self.checker.check_requests()
self.assertEqual(result['status'], None)
# second time request is in state new so we can accept
self.checker.set_request_ids(['770001'])
self.checker.check_requests()
self.assertTrue(result['status'])
def test_source_not_in_factory(self):
httpretty.register_uri(httpretty.GET,
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
APIURL + '/search/request?match=state%2F%40name%3D%27review%27+and+review%5B%40by_user%3D%27factory-source%27+and+%40state%3D%27new%27%5D&withfullhistory=1',
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
match_querystring = True,
body = """
<collection matches="1">
tests: add missing creator attribute to requests to satisfy osc.
2017-04-13 15:08:15 -05:00
<request id="261411" creator="lnussel">
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
<action type="maintenance_incident">
rename CPE -> Backports
2015-02-04 16:43:56 +01:00
<source project="home:lnussel:branches:openSUSE:Backports:SLE-12" package="plan" rev="71e76daf2c2e9ddb0b9208f54a14f608"/>
<target project="openSUSE:Maintenance" releaseproject="openSUSE:Backports:SLE-12"/>
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
</action>
<state name="review" who="maintbot" when="2014-11-13T13:22:02">
<comment></comment>
</state>
<review state="accepted" when="2014-11-13T13:22:02" who="maintbot" by_user="maintbot">
<comment>accepted</comment>
<history who="maintbot" when="2014-11-13T16:43:09">
<description>Review got accepted</description>
<comment>accepted</comment>
</history>
</review>
<review state="new" by_user="factory-source"/>
<history who="lnussel" when="2014-11-13T13:22:02">
<description>Request created</description>
<comment>test update</comment>
</history>
<history who="maintbot" when="2014-11-13T16:43:08">
<description>Request got a new review request</description>
</history>
<description>test update</description>
</request>
</collection>
""")
httpretty.register_uri(httpretty.GET,
APIURL + "/request/261411",
body = """
tests: add missing creator attribute to requests to satisfy osc.
2017-04-13 15:08:15 -05:00
<request id="261411" creator="lnussel">
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
<action type="maintenance_incident">
rename CPE -> Backports
2015-02-04 16:43:56 +01:00
<source project="home:lnussel:branches:openSUSE:Backports:SLE-12" package="plan" rev="71e76daf2c2e9ddb0b9208f54a14f608"/>
<target project="openSUSE:Maintenance" releaseproject="openSUSE:Backports:SLE-12"/>
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
</action>
<state name="review" who="maintbot" when="2014-11-13T13:22:02">
<comment></comment>
</state>
<review state="accepted" when="2014-11-13T13:22:02" who="maintbot" by_user="maintbot">
<comment>accepted</comment>
<history who="maintbot" when="2014-11-13T16:43:09">
<description>Review got accepted</description>
<comment>accepted</comment>
</history>
</review>
<review state="new" by_user="factory-source"/>
<history who="lnussel" when="2014-11-13T13:22:02">
<description>Request created</description>
<comment>test update</comment>
</history>
<history who="maintbot" when="2014-11-13T16:43:08">
<description>Request got a new review request</description>
</history>
<description>test update</description>
</request>
""")
httpretty.register_uri(httpretty.GET,
rename CPE -> Backports
2015-02-04 16:43:56 +01:00
APIURL + "/source/home:lnussel:branches:openSUSE:Backports:SLE-12/plan",
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
body = """
<directory name="plan" rev="1" vrev="1" srcmd5="b4ed19dc30c1b328168bc62a81ec6998">
<linkinfo project="home:lnussel:plan" package="plan" srcmd5="7a2353f73b29dba970702053229542a0" baserev="7a2353f73b29dba970702053229542a0" xsrcmd5="71e76daf2c2e9ddb0b9208f54a14f608" lsrcmd5="b4ed19dc30c1b328168bc62a81ec6998" />
<entry name="_link" md5="91f81d88456818a18a7332999fb2da18" size="125" mtime="1415807350" />
<entry name="plan.spec" md5="b6814215f6d2e8559b43de9a214b2cbd" size="8103" mtime="1413627959" />
</directory>
""")
httpretty.register_uri(httpretty.GET,
Fix httpretty using tests Looks like OSC in Tumbleweed changed behaviour of internal functions
2020-05-02 10:50:33 +02:00
APIURL + "/source/openSUSE:Factory/plan/_meta",
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
status = 404,
body = """
<status code="unknown_package">
<summary>openSUSE:Factory/plan</summary>
</status>
""")
leaper: adjust for SLE 15SP1 and SLE12SP4
2018-06-26 15:18:55 +02:00
httpretty.register_uri(httpretty.GET,
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
APIURL + '/source/openSUSE:Factory/00Meta/lookup.yml',
leaper: adjust for SLE 15SP1 and SLE12SP4
2018-06-26 15:18:55 +02:00
status = 404)
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
httpretty.register_uri(httpretty.GET,
Fix httpretty using tests Looks like OSC in Tumbleweed changed behaviour of internal functions
2020-05-02 10:50:33 +02:00
APIURL + '/search/request',
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
body = """
<collection matches="0">
</collection>
""")
Fix E203 This fixes incorrect whitespacing inside dictionaries.
2019-12-10 08:54:32 +01:00
result = { 'factory_source_declined': None }
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
def change_request(result, method, uri, headers):
Simplify httpretty usage Don't pass regexps but real URLs, otherwise the matching won't work. On travis and leap 15.1 we have httpretty 0.9.5 which won't uncover the problem, but on Tumbleweed we have 0.9.6 that shows it
2019-05-04 11:17:57 +02:00
query = parse_qs(urlparse(uri).query)
if query == {'by_user': ['factory-source'], 'cmd': ['changereviewstate'], 'newstate': ['declined']}:
new review bots factory-source and maintbot factory-source checks if submissions contain sources already accepted in Factory. maintbot makes sure maintenance submissions are authored by the Factory package maintainer. Both are based on a new generic ReviewBot.py class that can serve as common framework for review bots.
2014-10-08 14:31:55 +02:00
result['factory_source_declined'] = True
return (200, headers, '<status code="ok"/>')
httpretty.register_uri(httpretty.POST,
APIURL + "/request/261411",
body = lambda method, uri, headers: change_request(result, method, uri, headers))
self.checker.requests = []
self.checker.set_request_ids_search_review()
self.checker.check_requests()
self.assertTrue(result['factory_source_declined'])
if __name__ == '__main__':
unittest.main()
Reference in New Issue Copy Permalink