openSUSE-release-tools/osc-check_source.py

271 lines
10 KiB
Python
Raw Normal View History

2011-03-29 13:48:57 +02:00
#
# (C) 2011 coolo@suse.de, Novell Inc, openSUSE.org
# Distribute under GPLv2 or GPLv3
#
# Copy this script to ~/.osc-plugins/ or /var/lib/osc-plugins .
# Then try to run 'osc checker --help' to see the usage.
2011-03-30 14:29:01 +02:00
2011-03-29 13:48:57 +02:00
import socket
import os
import traceback
import subprocess
2013-03-21 11:34:18 +01:00
def _checker_parse_name(self, apiurl, project, package, revision=None, brief=False, verbose=False):
if revision:
url = makeurl(apiurl, ['source', project, package], { 'view':'info', 'parse':1, 'rev':revision})
else:
url = makeurl(apiurl, ['source', project, package], { 'view':'info', 'parse':1 } )
try:
f = http_GET(url)
except urllib2.HTTPError, err:
2013-03-21 11:34:18 +01:00
return None
xml = ET.parse(f)
name = xml.find('name')
if name is None or not name.text:
2013-03-21 11:34:18 +01:00
return None
2013-03-21 11:34:18 +01:00
return name.text
2011-03-30 13:49:57 +02:00
def _checker_change_review_state(self, opts, id, newstate, by_group='', by_user='', message='', supersed=None):
2011-03-30 13:50:46 +02:00
""" taken from osc/osc/core.py, improved:
- verbose option added,
- empty by_user=& removed.
- numeric id can be int().
"""
query = {'cmd': 'changereviewstate', 'newstate': newstate }
if by_group: query['by_group'] = by_group
if by_user: query['by_user'] = by_user
if supersed: query['superseded_by'] = supersed
2011-11-22 13:00:03 +01:00
# if message: query['comment'] = message
2011-03-30 13:50:46 +02:00
u = makeurl(opts.apiurl, ['request', str(id)], query=query)
2011-11-22 13:00:03 +01:00
f = http_POST(u, data=message)
2011-03-30 13:50:46 +02:00
root = ET.parse(f).getroot()
return root.attrib['code']
2011-03-29 13:48:57 +02:00
2011-03-30 14:29:01 +02:00
def _checker_prepare_dir(self, dir):
olddir=os.getcwd()
os.chdir(dir)
shutil.rmtree(".osc")
os.chdir(olddir)
2011-11-22 13:00:03 +01:00
def _checker_accept_request(self, opts, id, msg):
code = 100
2012-08-09 11:47:27 +02:00
query = { 'cmd': 'addreview', 'by_group':'opensuse-review-team' }
2011-11-22 13:00:03 +01:00
url = makeurl(opts.apiurl, ['request', str(id)], query)
2013-04-18 13:33:25 +02:00
if opts.verbose: print(url)
2011-11-22 13:00:03 +01:00
try:
r = http_POST(url, data="Please review sources")
except urllib2.HTTPError, err:
return 1
code = ET.parse(r).getroot().attrib['code']
if code == 100 or code == 'ok':
self._checker_change_review_state(opts, id, 'accepted', by_group='factory-auto', message=msg)
2013-04-18 13:33:25 +02:00
print("accepted " + msg)
2013-03-21 11:34:18 +01:00
# now gets risky
query = { 'cmd': 'addreview', 'by_user':'factory-repo-checker' }
url = makeurl(opts.apiurl, ['request', str(id)], query)
try:
r = http_POST(url, data="Please review build success")
except urllib2.HTTPError, err:
pass # there is no good mean to undo
2011-11-22 13:00:03 +01:00
return 0
2011-03-30 13:49:57 +02:00
def _checker_one_request(self, rq, cmd, opts):
2011-03-30 13:50:46 +02:00
if (opts.verbose):
2011-03-29 13:48:57 +02:00
ET.dump(rq)
print(opts)
id = int(rq.get('id'))
act_id = 0
approved_actions = 0
actions = rq.findall('action')
if len(actions) > 1:
msg = "2 actions in one SR is not supported - https://github.com/coolo/factory-auto/fork_select"
self._checker_change_review_state(opts, id, 'declined', by_group='factory-auto', message=msg)
2013-04-18 13:33:25 +02:00
print("declined " + msg)
return
2011-03-29 13:48:57 +02:00
for act in actions:
act_id += 1
_type = act.get('type');
if (_type == "submit"):
pkg = act.find('source').get('package')
prj = act.find('source').get('project')
rev = act.find('source').get('rev')
tprj = act.find('target').get('project')
tpkg = act.find('target').get('package')
2011-11-22 13:00:03 +01:00
src = { 'package': pkg, 'project': prj, 'rev':rev, 'error': None }
2011-03-29 13:48:57 +02:00
e = []
2011-03-30 13:50:46 +02:00
if not pkg:
2011-03-29 13:48:57 +02:00
e.append('no source/package in request %d, action %d' % (id, act_id))
2011-03-30 13:50:46 +02:00
if not prj:
2011-03-29 13:48:57 +02:00
e.append('no source/project in request %d, action %d' % (id, act_id))
if len(e): src.error = '; '.join(e)
e = []
2011-03-30 13:50:46 +02:00
if not tpkg:
2011-03-29 13:48:57 +02:00
e.append('no target/package in request %d, action %d; ' % (id, act_id))
2011-03-30 13:50:46 +02:00
if not prj:
2011-03-29 13:48:57 +02:00
e.append('no target/project in request %d, action %d; ' % (id, act_id))
# it is no error, if the target package dies not exist
subm_id = "SUBMIT(%d):" % id
2013-04-18 13:33:25 +02:00
print ("\n%s %s/%s -> %s/%s" % (subm_id,
2011-03-31 12:35:05 +02:00
prj, pkg,
2013-04-18 13:33:25 +02:00
tprj, tpkg))
2011-04-01 13:57:56 +02:00
dpkg = self._checker_check_devel_package(opts, tprj, tpkg)
2013-03-21 11:34:18 +01:00
#self._devel_projects['X11:QtDesktop/'] = 'rabbitmq'
#self._devel_projects['devel:languages:erlang/'] = 'ruby19'
#self._devel_projects['devel:languages:nodejs/'] = 'nodejs'
#self._devel_projects['X11:Enlightenment:Factory/'] = 'x2go'
#self._devel_projects['isv:ownCloud:owncloud-factory'] = 'owncloud'
#self._devel_projects['X11:Wayland/'] = 'wayland'
2011-04-01 13:57:56 +02:00
if dpkg:
[dprj, dpkg] = dpkg.split('/')
else:
dprj = None
if dprj and (dprj != prj or dpkg != pkg) and (not os.environ.has_key("IGNORE_DEVEL_PROJECTS")):
2011-04-01 13:57:56 +02:00
msg = "'%s/%s' is the devel package, submission is from '%s'" % (dprj, dpkg, prj)
self._checker_change_review_state(opts, id, 'declined', by_group='factory-auto', message=msg)
2013-04-18 13:33:25 +02:00
print("declined " + msg)
2011-04-01 13:57:56 +02:00
continue
if not dprj and not self._devel_projects.has_key(prj + "/"):
msg = "'%s' is not a valid devel project of %s - please pick one of the existent" % (prj, tprj)
self._checker_change_review_state(opts, id, 'declined', by_group='factory-auto', message=msg)
2013-04-18 13:33:25 +02:00
print("declined " + msg)
2011-04-01 13:57:56 +02:00
continue
2012-01-30 13:46:30 +01:00
dir = os.path.expanduser("~/co/%s" % str(id))
2011-03-29 13:48:57 +02:00
if os.path.exists(dir):
2013-04-18 13:33:25 +02:00
print("%s already exists" % dir)
2011-03-30 13:50:46 +02:00
continue
2011-03-29 13:48:57 +02:00
os.mkdir(dir)
os.chdir(dir)
2011-03-31 12:35:05 +02:00
try:
checkout_package(opts.apiurl, tprj, tpkg, pathname=dir,
server_service_files=True, expand_link=True)
self._checker_prepare_dir(tpkg)
os.rename(tpkg, "_old")
except urllib2.HTTPError:
2013-04-18 13:33:25 +02:00
print("failed to checkout %s/%s" % (tprj, tpkg))
2011-03-31 12:35:05 +02:00
pass
2011-03-30 14:33:11 +02:00
checkout_package(opts.apiurl, prj, pkg, revision=rev,
2011-03-30 14:29:01 +02:00
pathname=dir, server_service_files=True, expand_link=True)
2011-11-22 13:00:03 +01:00
os.rename(pkg, tpkg)
self._checker_prepare_dir(tpkg)
2011-03-30 14:29:01 +02:00
2013-03-21 11:34:18 +01:00
r=self._checker_parse_name(opts.apiurl, prj, pkg, revision=rev)
if r != tpkg:
2013-05-13 12:48:21 +02:00
msg = "A pkg submitted as %s has to build as 'Name: %s' - found Name '%s'" % (tpkg, tpkg, r)
2012-01-26 15:11:10 +01:00
self._checker_change_review_state(opts, id, 'declined', by_group='factory-auto', message=msg)
continue
2011-12-22 12:47:45 +01:00
civs = "LC_ALL=C perl /suse/coolo/checker/source-checker.pl _old %s 2>&1" % tpkg
2011-03-30 14:29:01 +02:00
p = subprocess.Popen(civs, shell=True, stdout=subprocess.PIPE, close_fds=True)
2011-03-29 13:48:57 +02:00
ret = os.waitpid(p.pid, 0)[1]
checked = p.stdout.readlines()
2011-11-22 13:00:03 +01:00
output = ' '.join(checked).translate(None, '\033')
os.chdir("/tmp")
2011-12-22 12:47:45 +01:00
2011-03-29 13:48:57 +02:00
if ret != 0:
2011-11-22 13:00:03 +01:00
msg = "Output of check script:\n" + output
self._checker_change_review_state(opts, id, 'declined', by_group='factory-auto', message=msg)
2013-04-18 13:33:25 +02:00
print("declined " + msg)
2012-01-30 13:46:30 +01:00
shutil.rmtree(dir)
2011-03-30 13:50:46 +02:00
continue
2011-03-29 13:48:57 +02:00
2012-01-26 15:11:10 +01:00
shutil.rmtree(dir)
2013-03-21 11:34:18 +01:00
msg="Check script succeeded"
2011-03-29 13:48:57 +02:00
if len(checked):
2011-11-22 13:00:03 +01:00
msg = msg + "\n\nOutput of check script (non-fatal):\n" + output
if self._checker_accept_request(opts, id, msg):
continue
2011-03-29 13:48:57 +02:00
else:
2011-03-30 14:33:11 +02:00
self._checker_change_review_state(opts, id, 'accepted',
by_group='factory-auto',
message="Unchecked request type %s" % _type)
2011-03-29 13:48:57 +02:00
2011-04-01 13:57:56 +02:00
def _checker_check_devel_package(self, opts, project, package):
if not self._devel_projects.has_key(project):
url = makeurl(opts.apiurl, ['search','package'], "match=[@project='%s']" % project)
f = http_GET(url)
root = ET.parse(f).getroot()
for p in root.findall('package'):
name = p.attrib['name']
d = p.find('devel')
if d != None:
dprj = d.attrib['project']
self._devel_projects["%s/%s" % (project, name)] = "%s/%s" % (dprj, d.attrib['package'])
# for new packages to check
self._devel_projects[dprj + "/"] = 1
2011-11-22 13:00:03 +01:00
elif not name.startswith("_product"):
2013-04-18 13:33:25 +02:00
print("NO DEVEL IN", name)
2011-04-01 13:57:56 +02:00
# mark we tried
self._devel_projects[project] = 1
try:
return self._devel_projects["%s/%s" % (project, package)]
except KeyError:
return None
2011-03-29 13:48:57 +02:00
2013-03-21 11:34:18 +01:00
def do_check_source(self, subcmd, opts, *args):
2011-03-29 13:48:57 +02:00
"""${cmd_name}: checker review of submit requests.
Usage:
2013-03-21 11:34:18 +01:00
osc check_source [OPT] [list] [FILTER|PACKAGE_SRC]
2011-03-29 13:48:57 +02:00
Shows pending review requests and their current state.
${cmd_option_list}
"""
if len(args) == 0:
raise oscerr.WrongArgs("Please give a subcommand to 'osc checker' or try 'osc help checker'")
2011-04-01 13:57:56 +02:00
self._devel_projects = {}
2011-03-29 13:48:57 +02:00
opts.verbose = False
from pprint import pprint
opts.apiurl = self.get_api_url()
tmphome = None
2011-11-22 13:00:03 +01:00
if args[0] == 'skip':
for id in args[1:]:
self._checker_accept_request(opts, id, "skip review")
return
2011-03-29 13:48:57 +02:00
ids = {}
for a in args:
if (re.match('\d+', a)):
ids[a] = 1
if (not len(ids)):
# xpath query, using the -m, -r, -s options
where = "@by_group='factory-auto'+and+@state='new'"
url = makeurl(opts.apiurl, ['search','request'], "match=state/@name='review'+and+review["+where+"]")
f = http_GET(url)
root = ET.parse(f).getroot()
for rq in root.findall('request'):
tprj = rq.find('action/target').get('project')
2011-03-30 13:49:57 +02:00
self._checker_one_request(rq, args[0], opts)
2011-03-29 13:48:57 +02:00
else:
# we have a list, use them.
for id in ids.keys():
url = makeurl(opts.apiurl, ['request', id])
f = http_GET(url)
xml = ET.parse(f)
root = xml.getroot()
2011-03-30 13:49:57 +02:00
self._checker_one_request(root, args[0], opts)
2011-03-30 14:29:01 +02:00
#Local Variables:
#mode: python
#py-indent-offset: 4
#tab-width: 8
#End: