ignore: remove validation since that is handled by RequestFinder.

This commit is contained in:
Jimmy Berry 2017-03-17 14:43:52 -05:00
parent 89c75ab227
commit 12cd69c6ab

View File

@ -17,13 +17,14 @@ class IgnoreCommand(object):
length = len(requests_ignored) length = len(requests_ignored)
for request_id in RequestFinder.find_sr(requests, self.api): for request_id in RequestFinder.find_sr(requests, self.api):
request_id = str(request_id) if request_id in requests_ignored:
print('Processing {}'.format(request_id)) print('{}: already ignored'.format(request_id))
check = self.check_and_comment(request_id, message) continue
if check is not True:
print('- {}'.format(check)) print('{}: ignored'.format(request_id))
elif request_id not in requests_ignored: requests_ignored[request_id] = message
requests_ignored[int(request_id)] = message if message:
self.comment.add_comment(request_id=str(request_id), comment=message)
diff = len(requests_ignored) - length diff = len(requests_ignored) - length
if diff > 0: if diff > 0:
@ -33,14 +34,3 @@ class IgnoreCommand(object):
print('No new requests to ignore') print('No new requests to ignore')
return True return True
def check_and_comment(self, request_id, message=None):
request = get_request(self.api.apiurl, request_id)
if not request:
return 'not found'
if request.actions[0].tgt_project != self.api.project:
return 'not targeting {}'.format(self.api.project)
if message:
self.comment.add_comment(request_id=request_id, comment=message)
return True