yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ReviewBot: copy default review messages before each review.

Browse Source
This commit is contained in:
Jimmy Berry 2017-06-20 16:31:25 -05:00
parent 3b1c11f45c
commit 2c1a21704d
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ReviewBot.py
View File

@ -215,6 +215,9 @@ class ReviewBot(object):
return None if nothing to do, True to accept, False to reject return None if nothing to do, True to accept, False to reject
""" """
# Copy original values to revert changes made to them.
self.review_messages = self.DEFAULT_REVIEW_MESSAGES.copy()
if self.only_one_action and len(req.actions) != 1: if self.only_one_action and len(req.actions) != 1:
self.review_messages['declined'] = 'Only one action per request' self.review_messages['declined'] = 'Only one action per request'
return False return False

6
check_source.py
View File

@ -32,12 +32,6 @@ class CheckSource(ReviewBot.ReviewBot):
self.staging_group = 'factory-staging' self.staging_group = 'factory-staging'
self.skip_add_reviews = False self.skip_add_reviews = False
def check_one_request(self, request):
# Copy original values to revert changes made to them.
self.review_messages = self.DEFAULT_REVIEW_MESSAGES.copy()
return super(CheckSource, self).check_one_request(request)
def check_source_submission(self, source_project, source_package, source_revision, target_project, target_package): def check_source_submission(self, source_project, source_package, source_revision, target_project, target_package):
super(CheckSource, self).check_source_submission(source_project, source_package, source_revision, target_project, target_package) super(CheckSource, self).check_source_submission(source_project, source_package, source_revision, target_project, target_package)

1
leaper.py
View File

@ -402,7 +402,6 @@ class Leaper(ReviewBot.ReviewBot):
return False return False
def check_one_request(self, req): def check_one_request(self, req):
self.review_messages = self.DEFAULT_REVIEW_MESSAGES.copy()
self.needs_legal_review = False self.needs_legal_review = False
self.needs_reviewteam = False self.needs_reviewteam = False
self.needs_release_manager = False self.needs_release_manager = False