From 48fe3836a645edee7c1a69297d1a8ff93edcf645 Mon Sep 17 00:00:00 2001 From: Jimmy Berry Date: Wed, 8 Nov 2017 23:45:37 -0600 Subject: [PATCH] repo_checker: review failed stagings with only openQA failures. Build failures may cause false negatives in repo_checker results, but openQA failures are not relevant and should be ignored. --- repo_checker.py | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/repo_checker.py b/repo_checker.py index 56159847..0990eb52 100755 --- a/repo_checker.py +++ b/repo_checker.py @@ -125,8 +125,20 @@ class RepoChecker(ReviewBot.ReviewBot): # Corrupted requests may reference non-existent projects and will # thus return a None status which should be considered not ready. if not status or str(status['overall_state']) not in ('testing', 'review', 'acceptable'): - self.logger.debug('{}: {} not ready'.format(request.reqid, group)) - continue + # Not in a "ready" state. + openQA_only = False # Not relevant so set to False. + if str(status['overall_state']) == 'failed': + # Exception to the rule is openQA only in failed state. + openQA_only = True + for project in api.project_status_walk(status): + if len(project['broken_packages']): + # Broken packages so not just openQA. + openQA_only = False + break + + if not openQA_only: + self.logger.debug('{}: {} not ready'.format(request.reqid, group)) + continue # Only interested if request is in consistent state. selected = api.project_status_requests('selected')