From 44f93dfa7c1fe65a81dd4dc612ac175d5130fed8 Mon Sep 17 00:00:00 2001 From: Stephan Kulow Date: Thu, 19 Jul 2018 08:41:16 +0200 Subject: [PATCH] repo_checker: Fix the review loop The break on openQA failures is a left over from 93ee829260a6abf094cbbc31e26eb21bf45e8f15 where we stopped the loop over subprojects. We don't want to break out of the review loop on openQA failures --- repo_checker.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/repo_checker.py b/repo_checker.py index f589f70f..096957f4 100755 --- a/repo_checker.py +++ b/repo_checker.py @@ -164,12 +164,9 @@ class RepoChecker(ReviewBot.ReviewBot): # Not in a "ready" state. openQA_only = False # Not relevant so set to False. if status and str(status['overall_state']) == 'failed': - # Exception to the rule is openQA only in failed state. - openQA_only = True - if len(status['broken_packages']): - # Broken packages so not just openQA. - openQA_only = False - break + # Exception to the rule is openQA only in failed state, + # Broken packages so not just openQA. + openQA_only = (len(status['broken_packages']) == 0) if not self.force and not openQA_only: self.logger.debug('{}: {} not ready'.format(request.reqid, group))