yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

check_source: decline the delete request if duplicated

Browse Source 
Decline the delete request in case there is pending delete/submit request to
the same package, if there is another submit request against the same package
that we should prefer the submit one which should be passed staging already,
what it means just queued for accepting, like request go through adi or virtual
accept delete request.
This commit is contained in:
Max Lin 2017-10-12 19:11:01 +08:00
parent a2ba667f26
commit 475b8473df
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
check_source.py
View File

@ -223,6 +223,16 @@ class CheckSource(ReviewBot.ReviewBot):
except urllib2.HTTPError: except urllib2.HTTPError:
return None return None
# Decline the delete request if there is another delete/submit request against the same package
query = "match=state/@name='new'+and+(action/target/@project='{}'+and+action/target/@package='{}')"\
"+and+(action/@type='delete'+or+action/@type='submit')".format(action.tgt_project, action.tgt_package)
url = osc.core.makeurl(self.apiurl, ['search', 'request'], query)
matches = ET.parse(osc.core.http_GET(url)).getroot()
if int(matches.attrib['matches']) > 1:
ids = [rq.attrib['id'] for rq in matches.findall('request')]
self.review_messages['declined'] = "There is a pending request %s to %s/%s in process." % (','.join(ids), action.tgt_project, action.tgt_package)
return False
# Decline the delete request against linked package. # Decline the delete request against linked package.
links = root.findall('sourceinfo/linked') links = root.findall('sourceinfo/linked')
if links is None or len(links) == 0: if links is None or len(links) == 0: