From 32dba4ab623b6f5aa2d8fc68a40313451c675cad Mon Sep 17 00:00:00 2001 From: Jimmy Berry Date: Fri, 10 Mar 2017 13:23:21 -0600 Subject: [PATCH 1/2] devel-project: fallback to project if package has no maintainers. --- devel-project.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/devel-project.py b/devel-project.py index 06dc90fc..3c299012 100755 --- a/devel-project.py +++ b/devel-project.py @@ -166,6 +166,10 @@ def maintainers_get(apiurl, project, package=None): for person in meta.findall('person[@role="maintainer"]'): userids.append(person.get('userid')) + if len(userids) == 0 and package is not None: + # Fallback to project if package has no maintainers. + return maintainers_get(apiurl, project) + return userids def remind_comment(apiurl, repeat_age, request_id, project, package=None): From df088b32bcb1de112f1cb8c7d99ce5bf8d8a4c6e Mon Sep 17 00:00:00 2001 From: Jimmy Berry Date: Fri, 10 Mar 2017 13:24:00 -0600 Subject: [PATCH 2/2] devel-project: drop user list if no maintainers. --- devel-project.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/devel-project.py b/devel-project.py index 3c299012..b75d5510 100755 --- a/devel-project.py +++ b/devel-project.py @@ -187,8 +187,11 @@ def remind_comment(apiurl, repeat_age, request_id, project, package=None): comment_api.delete(comment['id']) userids = sorted(maintainers_get(apiurl, project, package)) - users = ['@' + userid for userid in userids] - message = '{}: {}'.format(', '.join(users), REMINDER) + if len(userids): + users = ['@' + userid for userid in userids] + message = '{}: {}'.format(', '.join(users), REMINDER) + else: + message = REMINDER print(' ' + message) message = comment_api.add_marker(message, BOT_NAME) comment_api.add_comment(request_id=request_id, comment=message)