yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2846 from coolo/fix_group_bugowner

Browse Source 
Add test for group in bugowner line
This commit is contained in:
Stephan Kulow 2022-08-29 20:37:57 +02:00 committed by GitHub
commit 5a8f3dbeab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
check_bugowner.py
View File

@ -43,7 +43,7 @@ class CheckerBugowner(ReviewBot.ReviewBot):
if matched_package and matched_package != target_package: if matched_package and matched_package != target_package:
continue continue
if not self.valid_maintainer(matched_maintainer): if not self.valid_maintainer(matched_maintainer):
self.review_messages['declined'] = f"\n{matched_maintainer} could not be found on this instance." self.review_messages['declined'] += f"\n{matched_maintainer} could not be found on this instance."
return False return False
return True return True
self.review_messages['declined'] += f"\n{target_package } appears to be a new package and " + \ self.review_messages['declined'] += f"\n{target_package } appears to be a new package and " + \

14
tests/check_bugowner_tests.py
View File

@ -80,3 +80,17 @@ class TestCheckBugowner(OBSLocal.TestCase):
self.review_bot.check_requests() self.review_bot.check_requests()
self.assertReview(req_id, by_user=(self.bot_user, 'accepted')) self.assertReview(req_id, by_user=(self.bot_user, 'accepted'))
@pytest.mark.usefixtures("default_config")
def test_valid_bugowner_group(self):
"""Accept request with valid group maintainer"""
self.wf.create_group('coldpool')
req_id = self.wf.create_submit_request(
'devel:wine', 'merlot', description="This is a cool new package\nbugowner: group:coldpool").reqid
self.assertReview(req_id, by_user=(self.bot_user, 'new'))
self.review_bot.set_request_ids([req_id])
self.review_bot.check_requests()
self.assertReview(req_id, by_user=(self.bot_user, 'accepted'))