Merge pull request #2795 from coolo/bugowner_approval

check_bugowner: Decline new packages without bugowner entry

check_bugowner.py

@@ -19,6 +19,7 @@ class CheckerBugowner(ReviewBot.ReviewBot):
     def __init__(self, *args, **kwargs):
         ReviewBot.ReviewBot.__init__(self, *args, **kwargs)
         self.request_default_return = True
+        self.override_allow = False
 
     def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package):
         self.logger.info("%s/%s@%s -> %s/%s" % (src_project,
@@ -46,7 +47,7 @@ class CheckerBugowner(ReviewBot.ReviewBot):
                 return False
             return True
         self.review_messages['declined'] += f"\n{target_package } appears to be a new package and " + \
-            "no matching 'bugowner:' line could be found in the request description."
+            "no matching 'bugowner:' line could be found in the request description. See https://confluence.suse.com/x/WgH2OQ"
         return False
 
     def existing_url(self, url):

gocd/checkers.suse.gocd.yaml

@@ -39,7 +39,7 @@ pipelines:
             resources:
             - staging-bot
             tasks:
-            - script: ./check_bugowner.py -A https://api.suse.de --verbose --user=bugowner-checker --review=accept-onpass review
+            - script: ./check_bugowner.py -A https://api.suse.de --verbose --user=bugowner-checker review
   SLE15SP4.Project:
     group: SLE.Checkers
     lock_behavior: unlockWhenFinished

gocd/checkers.suse.gocd.yaml.erb

@@ -39,7 +39,7 @@ pipelines:
             resources:
             - staging-bot
             tasks:
-            - script: ./check_bugowner.py -A https://api.suse.de --verbose --user=bugowner-checker --review=accept-onpass review
+            - script: ./check_bugowner.py -A https://api.suse.de --verbose --user=bugowner-checker review
   SLE15SP4.Project:
     group: SLE.Checkers
     lock_behavior: unlockWhenFinished