From 1a969c433ec9b46283c95d0782dba922701f0f49 Mon Sep 17 00:00:00 2001 From: Jimmy Berry Date: Tue, 19 Sep 2017 15:09:04 -0500 Subject: [PATCH] osclib/stagingapi: accept_status_comment(): avoid making comments for empty projects. --- osclib/stagingapi.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/osclib/stagingapi.py b/osclib/stagingapi.py index 35b9a6e8..14922be0 100644 --- a/osclib/stagingapi.py +++ b/osclib/stagingapi.py @@ -1568,6 +1568,11 @@ class StagingAPI(object): self.set_prj_pseudometa(project, meta) def accept_status_comment(self, project, packages): + if not len(packages): + # Avoid making accept comments for empty projects which can occur + # when all requests are unselected or something like #1142. + return + # A single comment should be enough to notify everybody, since they are # already mentioned in the comments created by select/unselect. comment = 'Project "{}" accepted. ' \