yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

prepare to drop a comment always

Browse Source
This commit is contained in:
Ludwig Nussel 2015-05-20 17:53:50 +02:00
parent 97324c1ced
commit 6f56749b61
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
abichecker/abichecker.py
View File

@ -314,8 +314,8 @@ class ABIChecker(ReviewBot.ReviewBot):
self.review_messages = ReviewBot.ReviewBot.DEFAULT_REVIEW_MESSAGES
commentid, status, result = self.find_abichecker_comment(req)
if status == 'done':
commentid, state, result = self.find_abichecker_comment(req)
if state == 'done':
self.logger.debug("request %s already done, result: %s"%(req.reqid, result))
return
@ -326,10 +326,15 @@ class ABIChecker(ReviewBot.ReviewBot):
self.save_reports_to_db(req)
result = None
state = 'seen'
if ret is not None:
state = 'done'
result = 'passed' if ret else 'failed'
else:
# we probably don't want abichecker to spam here
# FIXME don't delete comment in this case
#if state is None and not self.text_summary:
# self.text_summary = 'abichecker will take a look later'
state = 'seen'
if commentid:
self.commentapi.delete(commentid)
self.post_comment(req, state, result)