From 7bcf94a35fb801b8965761ecff52a1698c2c914a Mon Sep 17 00:00:00 2001 From: Jimmy Berry Date: Tue, 20 Jun 2017 16:25:46 -0500 Subject: [PATCH] ReviewBot: provide request_default_return option and use in leaper. --- ReviewBot.py | 3 ++- leaper.py | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ReviewBot.py b/ReviewBot.py index 22ddf3af..ebbde1e7 100644 --- a/ReviewBot.py +++ b/ReviewBot.py @@ -79,6 +79,7 @@ class ReviewBot(object): self.fallback_group = None self.comment_api = CommentAPI(self.apiurl) self.bot_name = self.__class__.__name__ + self.request_default_return = None self.load_config() @@ -262,7 +263,7 @@ class ReviewBot(object): def check_action__default(self, req, a): self.logger.error("unhandled request type %s"%a.type) - return None + return self.request_default_return def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package): """ default implemention does nothing """ diff --git a/leaper.py b/leaper.py index b3a9f3d5..d38ed610 100755 --- a/leaper.py +++ b/leaper.py @@ -46,6 +46,9 @@ class Leaper(ReviewBot.ReviewBot): def __init__(self, *args, **kwargs): ReviewBot.ReviewBot.__init__(self, *args, **kwargs) + # ReviewBot options. + self.request_default_return = True + self.do_comments = True self.maintbot = MaintenanceChecker(*args, **kwargs) @@ -476,9 +479,8 @@ class Leaper(ReviewBot.ReviewBot): return request_ok def check_action__default(self, req, a): - super(Leaper, self).check_action__default(req, a) self.needs_release_manager = True - return True + return super(Leaper, self).check_action__default(req, a) class CommandLineInterface(ReviewBot.CommandLineInterface):