From eab1adb90b64067cf9b7e5bc79e39f049a8a6abe Mon Sep 17 00:00:00 2001 From: Jimmy Berry Date: Tue, 11 Apr 2017 15:34:29 -0500 Subject: [PATCH] devel-project: gracefully skip when removal of previous comment fails. Given that previous comment is used as a basis for determining the time since last reminder if it cannot be removed a new reminder should not be created. --- devel-project.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/devel-project.py b/devel-project.py index b75d5510..aa8f672b 100755 --- a/devel-project.py +++ b/devel-project.py @@ -184,7 +184,14 @@ def remind_comment(apiurl, repeat_age, request_id, project, package=None): return # Repeat notification so remove old comment. - comment_api.delete(comment['id']) + try: + comment_api.delete(comment['id']) + except HTTPError, e: + if e.code == 403: + # Gracefully skip when previous reminder was by another user. + print(' unable to remove previous reminder') + return + raise e userids = sorted(maintainers_get(apiurl, project, package)) if len(userids):