yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #100 from openSUSE/coolo_1795

Browse Source 
try harder not to set reviews of closed requests
This commit is contained in:
Alberto Planas 2014-03-06 11:46:31 +01:00
commit 869c0a7770
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
osclib/stagingapi.py
View File

@ -345,7 +345,7 @@ class StagingAPI(object):
self._remove_package_from_prj_pseudometa(project, package) self._remove_package_from_prj_pseudometa(project, package)
delete_package(self.apiurl, project, package, force=True, msg=msg) delete_package(self.apiurl, project, package, force=True, msg=msg)
self.set_review(request_id, project, state=review) self.set_review(request_id, project, state=review, msg=msg)
def create_package_container(self, project, package, disable_build=False): def create_package_container(self, project, package, disable_build=False):
""" """
@ -751,7 +751,7 @@ class StagingAPI(object):
url = self.makeurl(['request', str(request_id)], query) url = self.makeurl(['request', str(request_id)], query)
http_POST(url, data=msg) http_POST(url, data=msg)
def set_review(self, request_id, project, state='accepted'): def set_review(self, request_id, project, state='accepted', msg=None):
""" """
Sets review for request done by project Sets review for request done by project
:param request_id: request to change review for :param request_id: request to change review for
@ -760,15 +760,20 @@ class StagingAPI(object):
req = get_request(self.apiurl, str(request_id)) req = get_request(self.apiurl, str(request_id))
if not req: if not req:
raise oscerr.WrongArgs('Request {} not found'.format(request_id)) raise oscerr.WrongArgs('Request {} not found'.format(request_id))
# don't try to change reviews if the request is dead
if not req.state.name in ['new', 'review']:
return
cont = False cont = False
for i in req.reviews: for i in req.reviews:
if i.by_project == project and i.state == 'new': if i.by_project == project and i.state == 'new':
cont = True cont = True
if cont: if not cont:
return
if not msg:
msg = 'Reviewed by staging project "{}" with result: "{}"' msg = 'Reviewed by staging project "{}" with result: "{}"'
msg = msg.format(project, state) msg = msg.format(project, state)
self.change_review_state(request_id, state, by_project=project, self.change_review_state(request_id, state, by_project=project,
message=msg) message=msg)
def build_switch_prj(self, prj, state): def build_switch_prj(self, prj, state):
url = self.makeurl(['source', prj, '_meta']) url = self.makeurl(['source', prj, '_meta'])