yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

check_bugowner: Don't get tripped over trailing space

Browse Source
This commit is contained in:
Stephan Kulow 2022-11-11 07:09:06 +01:00
parent 8fe27f740c
commit 8b9933edfb
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
check_bugowner.py
View File

@ -31,10 +31,10 @@ class CheckerBugowner(ReviewBot.ReviewBot):
for line in self.request.description.splitlines():
matched_package = None
matched_maintainer = None
m = re.match(r'\s*bugowner:\s*(\S*)\s*$', line)
m = re.match(r'\s*bugowner:\s*(\S+)\s*$', line)
if m:
matched_maintainer = m.group(1)
m = re.match(r'\s*bugowner:\s(\S*)\s(\S*)\s*$', line)
m = re.match(r'\s*bugowner:\s(\S+)\s(\S+)\s*$', line)
if m:
matched_maintainer = m.group(2)
matched_package = m.group(1)

13
tests/check_bugowner_tests.py
View File

@ -81,6 +81,19 @@ class TestCheckBugowner(OBSLocal.TestCase):
self.assertReview(req_id, by_user=(self.bot_user, 'accepted'))
@pytest.mark.usefixtures("default_config")
def test_valid_bugowner_with_space(self):
"""Accept request with valid maintainer with space"""
self.wf.create_user('thegirl')
req_id = self.wf.create_submit_request('devel:wine', 'merlot', description="bugowner: thegirl ").reqid
self.assertReview(req_id, by_user=(self.bot_user, 'new'))
self.review_bot.set_request_ids([req_id])
self.review_bot.check_requests()
self.assertReview(req_id, by_user=(self.bot_user, 'accepted'))
@pytest.mark.usefixtures("default_config")
def test_valid_bugowner_group(self):
"""Accept request with valid group maintainer"""