From 8c6ef7ff8014e52b3eb95c1808b58f8c47a03717 Mon Sep 17 00:00:00 2001 From: Dominique Leuenberger Date: Tue, 12 Apr 2016 11:02:34 +0200 Subject: [PATCH] repochecker: Adjust the decline message for missing binaries Some users are confused as the old message "package never built" does not have to be true in many cases, especially on longer-lasting stagings. In this case, the binaries might have been built but have since been replaced by newer ones - the effect is the same: repo-checker can't receive them in order to perform the full checks. --- osclib/checkrepo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osclib/checkrepo.py b/osclib/checkrepo.py index 6c01ca62..12c1c58c 100644 --- a/osclib/checkrepo.py +++ b/osclib/checkrepo.py @@ -798,7 +798,7 @@ class CheckRepo(object): if arch.attrib['result'] == 'building': r_foundbuilding = repo_name if arch.attrib['result'] == 'outdated': - msg = "%s's sources were changed after submissions and the old sources never built. Please resubmit" % request.src_package + msg = "%s's sources were changed after submission: the relevant binaries are not available (never built or binaries replaced). Please resubmit" % request.src_package print 'DECLINED', msg self.change_review_state(request.request_id, 'declined', message=msg) # Next line is not needed, but for documentation