Merge pull request #517 from lnussel/master

Implement default action

ReviewBot.py

@@ -170,11 +170,9 @@ class ReviewBot(object):
         for a in req.actions:
             fn = 'check_action_%s'%a.type
             if not hasattr(self, fn):
-                self.logger.error("unhandled request type %s"%a.type)
-                ret = None
-            else:
-                func = getattr(self, fn)
-                ret = func(req, a)
+                fn = 'check_action__default'
+            func = getattr(self, fn)
+            ret = func(req, a)
             if ret == False or overall is None and ret is not None:
                 overall = ret
         return overall
@@ -208,6 +206,10 @@ class ReviewBot(object):
     def check_action_submit(self, req, a):
         return self.check_source_submission(a.src_project, a.src_package, a.src_rev, a.tgt_project, a.tgt_package)
 
+    def check_action__default(self, req, a):
+        self.logger.error("unhandled request type %s"%a.type)
+        ret = None
+
     def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package):
         """ default implemention does nothing """
         self.logger.info("%s/%s@%s -> %s/%s"%(src_project, src_package, src_rev, target_project, target_package))

check_tags_in_requests.py

@@ -142,22 +142,19 @@ Note: there is no whitespace behind before or after the number sign
     def check_action_submit(self, req, a):
         return self.checkTagNotRequiredOrInRequest(req, a)
 
-    def check_action_delete(self, req, a):
-        self.logger.info("Delete package %s/%s"%(a.tgt_package, req.reqid))
-        # accept delete request automatically
-        return True
-
-    def check_action_add_role(self, req, a):
-        self.logger.info("add_role request %s, accepting..."%req.reqid)
-        # accept add_role request automatically
-        return True
-
     def check_action_maintenance_incident(self, req, a):
         return self.checkTagInRequest(req, a)
 
     def check_action_maintenance_release(self, req, a):
         return self.checkTagInRequest(req, a)
 
+    def check_action__default(self, req, a):
+        # accept all other requests
+        self.logger.debug("auto accept request type %s"%a.type)
+        return True
+
+
+
 
 class CommandLineInterface(ReviewBot.CommandLineInterface):