yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #517 from lnussel/master

Browse Source 
Implement default action
This commit is contained in:
Ludwig Nussel 2016-06-02 17:59:12 +02:00
commit 9c559154be
2 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ReviewBot.py
View File

@ -170,9 +170,7 @@ class ReviewBot(object):
for a in req.actions: for a in req.actions:
fn = 'check_action_%s'%a.type fn = 'check_action_%s'%a.type
if not hasattr(self, fn): if not hasattr(self, fn):
self.logger.error("unhandled request type %s"%a.type) fn = 'check_action__default'
ret = None
else:
func = getattr(self, fn) func = getattr(self, fn)
ret = func(req, a) ret = func(req, a)
if ret == False or overall is None and ret is not None: if ret == False or overall is None and ret is not None:
@ -208,6 +206,10 @@ class ReviewBot(object):
def check_action_submit(self, req, a): def check_action_submit(self, req, a):
return self.check_source_submission(a.src_project, a.src_package, a.src_rev, a.tgt_project, a.tgt_package) return self.check_source_submission(a.src_project, a.src_package, a.src_rev, a.tgt_project, a.tgt_package)
def check_action__default(self, req, a):
self.logger.error("unhandled request type %s"%a.type)
ret = None
def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package): def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package):
""" default implemention does nothing """ """ default implemention does nothing """
self.logger.info("%s/%s@%s -> %s/%s"%(src_project, src_package, src_rev, target_project, target_package)) self.logger.info("%s/%s@%s -> %s/%s"%(src_project, src_package, src_rev, target_project, target_package))

17
check_tags_in_requests.py
View File

@ -142,22 +142,19 @@ Note: there is no whitespace behind before or after the number sign
def check_action_submit(self, req, a): def check_action_submit(self, req, a):
return self.checkTagNotRequiredOrInRequest(req, a) return self.checkTagNotRequiredOrInRequest(req, a)
def check_action_delete(self, req, a):
self.logger.info("Delete package %s/%s"%(a.tgt_package, req.reqid))
# accept delete request automatically
return True
def check_action_add_role(self, req, a):
self.logger.info("add_role request %s, accepting..."%req.reqid)
# accept add_role request automatically
return True
def check_action_maintenance_incident(self, req, a): def check_action_maintenance_incident(self, req, a):
return self.checkTagInRequest(req, a) return self.checkTagInRequest(req, a)
def check_action_maintenance_release(self, req, a): def check_action_maintenance_release(self, req, a):
return self.checkTagInRequest(req, a) return self.checkTagInRequest(req, a)
def check_action__default(self, req, a):
# accept all other requests
self.logger.debug("auto accept request type %s"%a.type)
return True
class CommandLineInterface(ReviewBot.CommandLineInterface): class CommandLineInterface(ReviewBot.CommandLineInterface):