yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add some doc strings.

Browse Source
This commit is contained in:
Alberto Planas 2014-03-06 15:22:04 +01:00
parent d5a677ce20
commit 9ecf003434
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osclib/request_finder.py
View File

@ -33,15 +33,23 @@ class RequestFinder:
self.srs = {}
def _filter_review_by_project(self, element, state):
"""
Takes a XML that contains a list of reviews and take the ones
that in state 'state'.
"""
reviews = [r.get('by_project')
for r in element.findall('review')
if r.get('by_project') and r.get('state') == state]
return reviews
def _new_review_by_project(self, request, element):
"""
Takes a XML that contains a list of reviews and return True if
'request' is in the list with state as 'new'.
"""
reviews = self._filter_review_by_project(element, 'new')
assert len(reviews) <= 1, 'Request "{}" have more than one review by project "{}"'.format(request,
reviews)
assert len(reviews) <= 1, 'Request "{}" have multiple review by project in new state "{}"'.format(request,
reviews)
return reviews[0] if reviews else None
def find_request_id(self, request):