From a36b8f9864e31135d6bc63c59501c71015e0ebd0 Mon Sep 17 00:00:00 2001
From: Stephan Kulow <coolo@suse.de>
Date: Tue, 5 Apr 2022 16:41:26 +0200
Subject: [PATCH] check_bugowner: Decline new packages without bugowner entry

---
 check_bugowner.py                | 3 ++-
 gocd/checkers.suse.gocd.yaml     | 2 +-
 gocd/checkers.suse.gocd.yaml.erb | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/check_bugowner.py b/check_bugowner.py
index 30ef36c6..e33d5fcd 100755
--- a/check_bugowner.py
+++ b/check_bugowner.py
@@ -19,6 +19,7 @@ class CheckerBugowner(ReviewBot.ReviewBot):
     def __init__(self, *args, **kwargs):
         ReviewBot.ReviewBot.__init__(self, *args, **kwargs)
         self.request_default_return = True
+        self.override_allow = False
 
     def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package):
         self.logger.info("%s/%s@%s -> %s/%s" % (src_project,
@@ -46,7 +47,7 @@ class CheckerBugowner(ReviewBot.ReviewBot):
                 return False
             return True
         self.review_messages['declined'] += f"\n{target_package } appears to be a new package and " + \
-            "no matching 'bugowner:' line could be found in the request description."
+            "no matching 'bugowner:' line could be found in the request description. See https://confluence.suse.com/x/WgH2OQ"
         return False
 
     def existing_url(self, url):
diff --git a/gocd/checkers.suse.gocd.yaml b/gocd/checkers.suse.gocd.yaml
index cda0bf7f..45e84b9e 100644
--- a/gocd/checkers.suse.gocd.yaml
+++ b/gocd/checkers.suse.gocd.yaml
@@ -39,7 +39,7 @@ pipelines:
             resources:
             - staging-bot
             tasks:
-            - script: ./check_bugowner.py -A https://api.suse.de --verbose --user=bugowner-checker --review=accept-onpass review
+            - script: ./check_bugowner.py -A https://api.suse.de --verbose --user=bugowner-checker review
   SLE15SP4.Project:
     group: SLE.Checkers
     lock_behavior: unlockWhenFinished
diff --git a/gocd/checkers.suse.gocd.yaml.erb b/gocd/checkers.suse.gocd.yaml.erb
index 23ed4d2b..0b6af404 100644
--- a/gocd/checkers.suse.gocd.yaml.erb
+++ b/gocd/checkers.suse.gocd.yaml.erb
@@ -39,7 +39,7 @@ pipelines:
             resources:
             - staging-bot
             tasks:
-            - script: ./check_bugowner.py -A https://api.suse.de --verbose --user=bugowner-checker --review=accept-onpass review
+            - script: ./check_bugowner.py -A https://api.suse.de --verbose --user=bugowner-checker review
   SLE15SP4.Project:
     group: SLE.Checkers
     lock_behavior: unlockWhenFinished