From a8623bb8d86b630d713b744c78052f8f6c0e225c Mon Sep 17 00:00:00 2001 From: Stephan Kulow Date: Fri, 18 Feb 2022 16:34:48 +0100 Subject: [PATCH] Handle E712 - don't compare with == to Booleans --- .flake8 | 2 +- ReviewBot.py | 2 +- biarchtool.py | 8 ++++---- deptool.py | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.flake8 b/.flake8 index 0c639743..53738911 100644 --- a/.flake8 +++ b/.flake8 @@ -1,4 +1,4 @@ [flake8] exclude = abichecker max-line-length = 100 -ignore = W503,W504,E501,F401,E128,E251,E201,E202,E302,E305,F841,E261,E712 +ignore = W503,W504,E501,F401,E128,E251,E201,E202,E302,E305,F841,E261 diff --git a/ReviewBot.py b/ReviewBot.py index 90a5d120..331cea60 100644 --- a/ReviewBot.py +++ b/ReviewBot.py @@ -295,7 +295,7 @@ class ReviewBot(object): elif self.review_mode == 'fallback-always': self.add_review(req, by_group=by_group, by_user=by_user, msg='Adding fallback reviewer') - if doit == True: + if doit: self.logger.debug("setting %s to %s" % (req.reqid, state)) if not self.dryrun: try: diff --git a/biarchtool.py b/biarchtool.py index 499b8bec..d6015e85 100755 --- a/biarchtool.py +++ b/biarchtool.py @@ -272,18 +272,18 @@ class BiArchTool(ToolBase.ToolBase): else: must_disable = True - if must_disable == False: + if not must_disable: if is_disabled: logger.info('enabling %s for %s', pkg, self.arch) for build in pkgmeta.findall("./build"): for n in build.findall("./disable[@arch='{}']".format(self.arch)): build.remove(n) changed = True - if changed == False: + if not changed: logger.error('build tag not found in %s/%s!?', pkg, self.arch) else: logger.debug('%s already enabled for %s', pkg, self.arch) - elif must_disable == True: + elif must_disable: if not is_disabled: logger.info('disabling %s for %s', pkg, self.arch) bn = pkgmeta.find('build') @@ -300,7 +300,7 @@ class BiArchTool(ToolBase.ToolBase): for n in build.findall("./enable[@arch='{}']".format(self.arch)): build.remove(n) changed = True - if changed == False: + if not changed: logger.error('build tag not found in %s/%s!?', pkg, self.arch) if changed: diff --git a/deptool.py b/deptool.py index e9f9ec2c..8d5e6ce7 100755 --- a/deptool.py +++ b/deptool.py @@ -80,7 +80,7 @@ class DepTool(cmdln.Cmdln): name = r r += '.repo' parser.read('/'.join((repodir, r))) - if onlyenabled == False or parser.get(name, 'enabled') == '1': + if onlyenabled is False or parser.get(name, 'enabled') == '1': repo = self.pool.add_repo(name) repo.add_solv(solvfile % name) if parser.has_option(name, 'priority'):