check_source: check if member of staging group before attempting to skip.
SLE likes to be different for the sake of it.
This commit is contained in:
parent
1f8bf215ec
commit
a87cca01b7
@ -16,6 +16,7 @@ import osc.core
|
|||||||
from osclib.conf import Config
|
from osclib.conf import Config
|
||||||
from osclib.core import devel_project_get
|
from osclib.core import devel_project_get
|
||||||
from osclib.core import devel_project_fallback
|
from osclib.core import devel_project_fallback
|
||||||
|
from osclib.core import group_members
|
||||||
import urllib2
|
import urllib2
|
||||||
import ReviewBot
|
import ReviewBot
|
||||||
from osclib.conf import str2bool
|
from osclib.conf import str2bool
|
||||||
@ -174,10 +175,13 @@ class CheckSource(ReviewBot.ReviewBot):
|
|||||||
|
|
||||||
if self.only_changes():
|
if self.only_changes():
|
||||||
self.logger.debug('only .changes modifications')
|
self.logger.debug('only .changes modifications')
|
||||||
if self.staging_group and not self.dryrun:
|
if self.staging_group and self.review_user in group_members(self.apiurl, self.staging_group):
|
||||||
osc.core.change_review_state(self.apiurl, str(self.request.reqid), 'accepted',
|
if not self.dryrun:
|
||||||
by_group=self.staging_group,
|
osc.core.change_review_state(self.apiurl, str(self.request.reqid), 'accepted',
|
||||||
message='skipping the staging process since only .changes modifications')
|
by_group=self.staging_group,
|
||||||
|
message='skipping the staging process since only .changes modifications')
|
||||||
|
else:
|
||||||
|
self.logger.debug('unable to skip staging review since not a member of staging group')
|
||||||
elif self.repo_checker is not None:
|
elif self.repo_checker is not None:
|
||||||
self.add_review(self.request, by_user=self.repo_checker, msg='Please review build success')
|
self.add_review(self.request, by_user=self.repo_checker, msg='Please review build success')
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user