yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ReviewBot: accept patchinfo action reviews instead of ignore.

Browse Source 
Ignore is used to wait for a change to occur while patchinfo should never
affect the result. Since all actions must be accepted for the request to
be accepted setting patchinfo to accept is the correct way to ignore it.
This commit is contained in:
Jimmy Berry 2018-11-12 16:22:27 -06:00
parent 2a9183f2b8
commit ac798df607
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ReviewBot.py
View File

@ -393,7 +393,7 @@ class ReviewBot(object):
def check_action_maintenance_incident(self, req, a): def check_action_maintenance_incident(self, req, a):
if self._is_patchinfo(a.src_package): if self._is_patchinfo(a.src_package):
self.logger.debug('ignoring patchinfo action') self.logger.debug('ignoring patchinfo action')
return None return True
# Duplicate src_package as tgt_package since prior to assignment to a # Duplicate src_package as tgt_package since prior to assignment to a
# specific incident project there is no target package (odd API). After # specific incident project there is no target package (odd API). After
@ -416,7 +416,8 @@ class ReviewBot(object):
pkgname = a.src_package pkgname = a.src_package
if self._is_patchinfo(pkgname): if self._is_patchinfo(pkgname):
self.logger.debug('ignoring patchinfo action') self.logger.debug('ignoring patchinfo action')
return None return True
linkpkg = self._get_linktarget_self(a.src_project, pkgname) linkpkg = self._get_linktarget_self(a.src_project, pkgname)
if linkpkg is not None: if linkpkg is not None:
pkgname = linkpkg pkgname = linkpkg

2
check_maintenance_incidents.py
View File

@ -116,7 +116,7 @@ class MaintenanceChecker(ReviewBot.ReviewBot):
def check_action_maintenance_incident(self, req, a): def check_action_maintenance_incident(self, req, a):
if a.src_package == 'patchinfo': if a.src_package == 'patchinfo':
return None return True
self._check_maintainer_review_needed(req, a) self._check_maintainer_review_needed(req, a)