diff --git a/.flake8 b/.flake8 index 18bf44ca..10cce722 100644 --- a/.flake8 +++ b/.flake8 @@ -1,4 +1,4 @@ [flake8] exclude = .open-build-service/, abichecker, openqa, openqa-maintenance.py max-line-length = 100 -ignore = E501,F401,E302,E128,E251,E201,E202,E305,F841,E261,E265,E266,E712,E401,E126,E502,E711,E125,E123,W293,W391,E101,E713,E124,E127,E701,E714,W503,W504,E129,E741,E722,E731 +ignore = E501,F401,E128,E251,E201,E202,E302,E305,F841,E261,E265,E712,E126,E711,E125,E123,E101,E713,E124,E127,E701,E714,W504,E129,E741,E722,E731 diff --git a/ReviewBot.py b/ReviewBot.py index bc58ae59..be55bb5e 100644 --- a/ReviewBot.py +++ b/ReviewBot.py @@ -1,7 +1,9 @@ #!/usr/bin/python3 from pprint import pprint -import os, sys, re +import os +import sys +import re import logging from optparse import OptionParser import cmdln @@ -883,10 +885,10 @@ class CommandLineInterface(cmdln.Cmdln): if user is None and group is None: user = conf.get_apiurl_usr(apiurl) - return self.clazz(apiurl = apiurl, \ - dryrun = self.options.dry, \ - user = user, \ - group = group, \ + return self.clazz(apiurl = apiurl, + dryrun = self.options.dry, + user = user, + group = group, logger = self.logger) def do_id(self, subcmd, opts, *args): diff --git a/check_maintenance_incidents.py b/check_maintenance_incidents.py index e17413a1..2c26f902 100755 --- a/check_maintenance_incidents.py +++ b/check_maintenance_incidents.py @@ -1,7 +1,9 @@ #!/usr/bin/python3 from pprint import pprint -import os, sys, re +import os +import re +import sys import logging from optparse import OptionParser import cmdln diff --git a/check_source_in_factory.py b/check_source_in_factory.py index b9e5bc34..828c3f40 100755 --- a/check_source_in_factory.py +++ b/check_source_in_factory.py @@ -1,7 +1,9 @@ #!/usr/bin/python3 from pprint import pprint -import os, sys, re +import os +import sys +import re import logging from optparse import OptionParser import cmdln diff --git a/check_tags_in_requests.py b/check_tags_in_requests.py index a2afc066..a9dda6a1 100755 --- a/check_tags_in_requests.py +++ b/check_tags_in_requests.py @@ -138,4 +138,3 @@ class CommandLineInterface(ReviewBot.CommandLineInterface): if __name__ == "__main__": app = CommandLineInterface() sys.exit(app.main()) - diff --git a/factory-package-news/factory-package-news-web.py b/factory-package-news/factory-package-news-web.py index e3d9c9cb..fe824e03 100755 --- a/factory-package-news/factory-package-news-web.py +++ b/factory-package-news/factory-package-news-web.py @@ -69,7 +69,7 @@ def diff(version): if not os.path.exists(os.path.join(_dir, version)): return "invalid version", 400 import subprocess - cmd = [os.path.dirname(os.path.abspath(__file__)) + '/factory-package-news.py', \ + cmd = [os.path.dirname(os.path.abspath(__file__)) + '/factory-package-news.py', 'diff', '--dir', _dir, "current", version] app.logger.debug(cmd) response = make_response(subprocess.check_output(cmd)) @@ -85,4 +85,3 @@ if __name__ == '__main__': app.run(debug=options.debug, host=options.host) application = app - diff --git a/factory-package-news/factory-package-news.py b/factory-package-news/factory-package-news.py index b2f4a75b..e4145d1d 100755 --- a/factory-package-news/factory-package-news.py +++ b/factory-package-news/factory-package-news.py @@ -1,7 +1,9 @@ #!/usr/bin/python3 from pprint import pprint -import os, sys, io +import io +import os +import sys import logging from optparse import OptionParser import rpm diff --git a/tests/factory_source_tests.py b/tests/factory_source_tests.py index bffa0c22..b6115acf 100644 --- a/tests/factory_source_tests.py +++ b/tests/factory_source_tests.py @@ -42,8 +42,8 @@ class TestFactorySourceAccept(unittest.TestCase): self.logger = logging.getLogger(__file__) self.logger.setLevel(logging.DEBUG) - self.checker = FactorySourceChecker(apiurl = APIURL, \ - user = 'factory-source', \ + self.checker = FactorySourceChecker(apiurl = APIURL, + user = 'factory-source', logger = self.logger) self.checker.override_allow = False # Test setup cannot handle. diff --git a/tests/maintenance_tests.py b/tests/maintenance_tests.py index eeb16c50..28e67da1 100644 --- a/tests/maintenance_tests.py +++ b/tests/maintenance_tests.py @@ -37,8 +37,8 @@ class TestMaintenance(unittest.TestCase): self.logger = logging.getLogger(__file__) self.logger.setLevel(logging.DEBUG) - self.checker = MaintenanceChecker(apiurl = APIURL, \ - user = 'maintbot', \ + self.checker = MaintenanceChecker(apiurl = APIURL, + user = 'maintbot', logger = self.logger) self.checker.override_allow = False # Test setup cannot handle.