yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #774 from jberry-suse/source-checker-escape

Browse Source 
source-checker: utilize array system() calls to handle unescaped input.
This commit is contained in:
Ludwig Nussel 2017-03-22 09:29:15 +01:00 committed by GitHub
commit b6f2e8cd9f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source-checker.pl
View File

@ -75,7 +75,7 @@ for my $spec (glob("$dir/*.spec")) {
$ret = 1;
}
if (-f "$old/$changes") {
if (system("cmp -s $old/$changes $dir/$changes")) {
if (system(("cmp", "-s", "$old/$changes", "$dir/$changes"))) {
$changes_updated = 1;
}
}
@ -189,7 +189,7 @@ if (-d "$old") {
}
close(OSPEC);
close(NSPEC);
system("cp $spec $spec.beforeurlstrip");
system(("cp", "$spec", "$spec.beforeurlstrip"));
rename("$spec.new", "$spec") || die "rename failed";
}