yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow to disable the check of delete requests per config

Browse Source 
SLE service packs are just too complex to check delete requests sanely,
so better disable it. For next SLE we would enable it though

Fixes #2221 and ##2282
This commit is contained in:
Stephan Kulow 2020-03-24 09:04:21 +01:00
parent 2e3dc21c85
commit b98500af39
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
staging-installcheck.py
View File

@ -15,6 +15,7 @@ from osc import conf
from osclib.comments import CommentAPI from osclib.comments import CommentAPI
from osclib.conf import Config from osclib.conf import Config
from osclib.conf import str2bool
from osclib.core import (builddepinfo, depends_on, duplicated_binaries_in_repo, from osclib.core import (builddepinfo, depends_on, duplicated_binaries_in_repo,
fileinfo_ext_all, repository_arch_state, fileinfo_ext_all, repository_arch_state,
repository_path_expand, target_archs) repository_path_expand, target_archs)
@ -42,6 +43,7 @@ class InstallChecker(object):
self.ignore_duplicated = set(self.config.get('installcheck-ignore-duplicated-binaries', '').split(' ')) self.ignore_duplicated = set(self.config.get('installcheck-ignore-duplicated-binaries', '').split(' '))
self.ignore_conflicts = set(self.config.get('installcheck-ignore-conflicts', '').split(' ')) self.ignore_conflicts = set(self.config.get('installcheck-ignore-conflicts', '').split(' '))
self.ignore_deletes = str2bool(self.config.get('installcheck-ignore-deletes', 'False'))
def check_required_by(self, fileinfo, provides, requiredby, built_binaries, comments): def check_required_by(self, fileinfo, provides, requiredby, built_binaries, comments):
if requiredby.get('name') in built_binaries: if requiredby.get('name') in built_binaries:
@ -69,7 +71,7 @@ class InstallChecker(object):
def check_delete_request(self, req, to_ignore, comments): def check_delete_request(self, req, to_ignore, comments):
package = req.get('package') package = req.get('package')
if package in to_ignore: if package in to_ignore or self.ignore_deletes:
self.logger.info('Delete request for package {} ignored'.format(package)) self.logger.info('Delete request for package {} ignored'.format(package))
return True return True