yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2227 from jberry-suse/ReviewBot-add-review-403

Browse Source 
ReviewBot: add_review(): handle 403 as expected when superseded/rovoked.
This commit is contained in:
Jimmy Berry 2019-09-18 20:30:19 -05:00 committed by GitHub
commit c185be8c8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
ReviewBot.py
View File

@ -322,7 +322,15 @@ class ReviewBot(object):
key = request_action_key(self.action)
msg = yaml.dump({key: msg}, default_flow_style=False)
r = osc.core.http_POST(u, data=msg)
try:
r = osc.core.http_POST(u, data=msg)
except HTTPError as e:
if e.code != 403:
raise e
del query['cmd']
self.logger.info('unable to add review {} with message: {}'.format(query, msg))
return
code = ET.parse(r).getroot().attrib['code']
if code != 'ok':
raise Exception('non-ok return code: {}'.format(code))
@ -333,14 +341,7 @@ class ReviewBot(object):
self.logger.warning('no devel project found for {}/{}'.format(project, package))
return False
try:
self.add_review(request, by_project=devel_project, by_package=devel_package, msg=message)
except HTTPError as e:
# could happen when the bot is not actually a reviewer and has no permissions
if e.code != 403:
raise e
self.logger.error('failed to add devel project review for {}/{}'.format(devel_project, devel_package))
return False
self.add_review(request, by_project=devel_project, by_package=devel_package, msg=message)
return True